Skip to content

refactor(controller): controller no longer responsible for SingletonClientGenerator creation #6077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ivankatliarchuk wants to merge 8 commits into
base: master
Choose a base branch
from
Open

refactor(controller): controller no longer responsible for SingletonClientGenerator creation #6077

ivankatliarchuk wants to merge 8 commits into from

Conversation

@ivankatliarchuk
Copy link
Member

@ivankatliarchuk ivankatliarchuk commented Jan 2, 2026 •
edited
Loading

What does it do ?

Controller to focus on orchestration

Motivation

Slicing PR #6076

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

@ivankatliarchuk ivankatliarchuk marked this pull request as draft January 2, 2026 12:06
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 2, 2026
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 2, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mloiseleur for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from szuecs January 2, 2026 12:06
@k8s-ci-robot k8s-ci-robot added the controller Issues or PRs related to the controller label Jan 2, 2026
@k8s-ci-robot k8s-ci-robot requested a review from vflaux January 2, 2026 12:06
@k8s-ci-robot k8s-ci-robot added source size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 2, 2026
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 2, 2026
@coveralls
Copy link

coveralls commented Jan 2, 2026 •
edited
Loading

Pull Request Test Coverage Report for Build 20775819698

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 179 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.002%) to 78.896%
Files with Coverage Reduction New Missed Lines %
execute.go 40 60.78%
store.go 139 44.09%
Totals Coverage Status
Change from base Build 20774403164: -0.002%
Covered Lines: 15903
Relevant Lines: 20157
💛 - Coveralls

@ivankatliarchuk ivankatliarchuk marked this pull request as ready for review January 2, 2026 13:30
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 2, 2026
@ivankatliarchuk ivankatliarchuk changed the title refactore(controller): abstract things that should not be in controller refactore(controller): remove SingletonClientGenerator creation from controller Jan 2, 2026
ivankatliarchuk
ivankatliarchuk commented Jan 2, 2026
View reviewed changes
@ivankatliarchuk ivankatliarchuk changed the title refactore(controller): remove SingletonClientGenerator creation from controller refactore(controller): move responsibility to create SingletonClientGenerator Jan 2, 2026
@ivankatliarchuk ivankatliarchuk changed the title refactore(controller): move responsibility to create SingletonClientGenerator refactore(controller): conroller no longer responsible for SingletonClientGenerator creation Jan 2, 2026
@mloiseleur mloiseleur changed the title refactore(controller): conroller no longer responsible for SingletonClientGenerator creation refactore(controller): controller no longer responsible for SingletonClientGenerator creation Jan 2, 2026
@mloiseleur mloiseleur changed the title refactore(controller): controller no longer responsible for SingletonClientGenerator creation refactor(controller): controller no longer responsible for SingletonClientGenerator creation Jan 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@szuecs szuecs Awaiting requested review from szuecs

@vflaux vflaux Awaiting requested review from vflaux

@mloiseleur mloiseleur Awaiting requested review from mloiseleur

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. controller Issues or PRs related to the controller size/L Denotes a PR that changes 100-499 lines, ignoring generated files. source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ivankatliarchuk @k8s-ci-robot @coveralls