-
Notifications
You must be signed in to change notification settings - Fork 2.8k
refactor(aws): abstract provider-specific boolean parsing #6078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…omprehensive tests Signed-off-by: u-kai <[email protected]>
…date consumers Signed-off-by: u-kai <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @u-kai. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
Pull Request Test Coverage Report for Build 20700489134Details
💛 - Coveralls |
Signed-off-by: u-kai <[email protected]>
What does it do ?
This PR introduces a small abstraction for reading provider-specific boolean values
(e.g.
"true"/"false") instead of comparing string literals at call sites.Motivation
This PR is a follow-up to the ongoing AWS alias refactoring discussion.
During review, it was suggested that directly comparing provider-specific string values
(e.g.
prop != "true" && prop != "false") is harder to reason about and more error-prone.Rather than changing the existing approach in-place, this PR isolates the boolean parsing
logic so different approaches can be evaluated side by side.
Note that this PR intentionally does not update the
AdjustEndpointslogic inprovider/aws, as that refactor is being handled in a separate, ongoing PR.More