Skip to content

Conversation

@ivankatliarchuk
Copy link
Member

@ivankatliarchuk ivankatliarchuk commented Jan 4, 2026

What does it do ?

  • Extract CRD generation logic into scripts/generate-crd.sh for better maintainability (required in makefile and github action)
  • Add CI workflow to validate CRD files are up-to-date and when go.tool.mod changes
  • Add make tools-deps target to update tool dependencies

Follow-up

  • update tools version and validate regenerated CRD (latest controller-gen may produce new changes)
Screenshot 2026-01-04 at 17 06 23

Motivation

  • Different controller-gen versions produce different output
  • Ensures generated files stay in sync with tool dependencies
  • Prevents CI failures from stale generated code
  • Provides make tools-deps until Dependabot supports go.tool.mod (#12050)

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mloiseleur for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from szuecs and vflaux January 4, 2026 17:21
@k8s-ci-robot k8s-ci-robot added github_actions Pull requests that update GitHub Actions code cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. scripts Issues or PRs related to internal scripts size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 4, 2026
@ivankatliarchuk ivankatliarchuk changed the title chore(tools): refactor CRD generation and add validation workflow chore(tools): CRD generation script change and add validation workflow Jan 4, 2026
@coveralls
Copy link

coveralls commented Jan 4, 2026

Pull Request Test Coverage Report for Build 20724418971

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.005%) to 78.794%

Files with Coverage Reduction New Missed Lines %
openshift_route.go 1 84.29%
Totals Coverage Status
Change from base Build 20661074501: -0.005%
Covered Lines: 15799
Relevant Lines: 20051

💛 - Coveralls

@ivankatliarchuk ivankatliarchuk force-pushed the chore-tools branch 3 times, most recently from 37a5a67 to 13d0bcd Compare January 4, 2026 17:40
@ivankatliarchuk ivankatliarchuk requested a review from vflaux January 5, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chart cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. github_actions Pull requests that update GitHub Actions code scripts Issues or PRs related to internal scripts size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants