feat(source): add unstructured source#6172
Open
ivankatliarchuk wants to merge 10 commits intokubernetes-sigs:masterfrom
Open
feat(source): add unstructured source#6172ivankatliarchuk wants to merge 10 commits intokubernetes-sigs:masterfrom
ivankatliarchuk wants to merge 10 commits intokubernetes-sigs:masterfrom
Conversation
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Pull Request Test Coverage Report for Build 21788334937Details
💛 - Coveralls |
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
0489f54 to
995236f
Compare
c45dd7f to
78f2b7b
Compare
79a2707 to
b8cba40
Compare
3 tasks
e1e01f4 to
8e032e3
Compare
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
8e032e3 to
255d6e1
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do ?
A new unstructured source that creates DNS records from any Kubernetes custom resource using Go templates.
Supporting every possible ingress or product isn’t practical. For example, it’s fairly common to have custom products, and ExternalDNS doesn’t really fit that model today, as it doesn’t provide even basic support for custom sources.
Added flags
Motivation
We shouldn't have to wait for external-dns to add built-in support for some specific CRDs. With this source, they can point external-dns at any resource (KubeVirt VMs, Crossplane resources, MetalLB pools, etc.) and use templates to extract hostnames and targets from .spec or .status fields.
Fixes #3437
Fixes #5104
First attempt #3490. That was abandoned
More
I could slice this PR, move tests to another PR and 400+ lines in docs