Skip to content

chore(source): standardize sources with merge endpionts and deduplication#6174

Open
ivankatliarchuk wants to merge 1 commit intokubernetes-sigs:masterfrom
gofogo:chore-merge-endpoint-deduplicate-targets
Open

chore(source): standardize sources with merge endpionts and deduplication#6174
ivankatliarchuk wants to merge 1 commit intokubernetes-sigs:masterfrom
gofogo:chore-merge-endpoint-deduplicate-targets

Conversation

@ivankatliarchuk
Copy link
Member

@ivankatliarchuk ivankatliarchuk commented Feb 7, 2026

What does it do ?

  • MergeEndpoint method sorting and deduplicate targets
  • All sources to utilize merge endpoints method, as there is very little reason to push duplication upstream to plan/provider

Motivation

  • Standarise sources output

Relates #6192

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly
┌──────────┬───────┐
│ Category │ Lines │
├──────────┼───────┤
│ Non-test │ +52   │
├──────────┼───────┤
│ Test     │ +119  │
├──────────┼───────┤
│ Ratio    │ 1:2.2│
└──────────┴───────┘

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign szuecs for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 7, 2026
@ivankatliarchuk ivankatliarchuk force-pushed the chore-merge-endpoint-deduplicate-targets branch 2 times, most recently from 3f10299 to 57057d7 Compare February 7, 2026 19:53
@coveralls
Copy link

coveralls commented Feb 7, 2026

Pull Request Test Coverage Report for Build 21795351288

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 303 unchanged lines in 12 files lost coverage.
  • Overall coverage decreased (-0.02%) to 79.142%

Files with Coverage Reduction New Missed Lines %
utils.go 2 97.1%
openshift_route.go 10 84.38%
endpoint.go 11 85.76%
istio_gateway.go 12 87.5%
f5_virtualserver.go 14 78.13%
contour_httpproxy.go 14 82.96%
ingress.go 15 88.3%
ambassador_host.go 15 82.64%
skipper_routegroup.go 28 37.97%
istio_virtualservice.go 29 86.74%
Totals Coverage Status
Change from base Build 21559764040: -0.02%
Covered Lines: 16027
Relevant Lines: 20251

💛 - Coveralls

@ivankatliarchuk ivankatliarchuk force-pushed the chore-merge-endpoint-deduplicate-targets branch 6 times, most recently from 8e4bf8e to 6e60e19 Compare February 7, 2026 20:51
…te targets

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
@ivankatliarchuk ivankatliarchuk force-pushed the chore-merge-endpoint-deduplicate-targets branch from 6e60e19 to e04b801 Compare February 8, 2026 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. source

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants