Skip to content

linter(goimports): Mixed import groups (internal before external)#6238

Open
ivankatliarchuk wants to merge 1 commit intokubernetes-sigs:masterfrom
gofogo:fix-goimports-tests
Open

linter(goimports): Mixed import groups (internal before external)#6238
ivankatliarchuk wants to merge 1 commit intokubernetes-sigs:masterfrom
gofogo:fix-goimports-tests

Conversation

@ivankatliarchuk
Copy link
Member

What does it do ?

Make sure our tests compliant with Go imports

Motivation

The correct import in GO should produce standard 3-group layout

  import (
      // 1. stdlib
      "fmt"

      // 2. external
      "k8s.io/apimachinery/pkg/..."

      // 3. internal (local-prefix)
      "sigs.k8s.io/external-dns/..."
  )

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
@k8s-ci-robot k8s-ci-robot requested a review from szuecs March 1, 2026 09:46
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mloiseleur for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the controller Issues or PRs related to the controller label Mar 1, 2026
@k8s-ci-robot k8s-ci-robot requested a review from vflaux March 1, 2026 09:46
@k8s-ci-robot k8s-ci-robot added internal Issues or PRs related to internal code metrics Issues or PRs related to metrics plan Issues or PRs related to external-dns plan provider Issues or PRs related to a provider registry Issues or PRs related to a registry source size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 1, 2026
@coveralls
Copy link

Pull Request Test Coverage Report for Build 22540787539

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.165%

Totals Coverage Status
Change from base Build 22540459008: 0.0%
Covered Lines: 16057
Relevant Lines: 20283

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. controller Issues or PRs related to the controller internal Issues or PRs related to internal code metrics Issues or PRs related to metrics plan Issues or PRs related to external-dns plan provider Issues or PRs related to a provider registry Issues or PRs related to a registry size/M Denotes a PR that changes 30-99 lines, ignoring generated files. source

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants