Skip to content

chore(deps): Upgrade dnsimple client to 8.3.0#6372

Open
weppos wants to merge 4 commits intokubernetes-sigs:masterfrom
weppos:upgrade-dnsimple-client-8.3.0
Open

chore(deps): Upgrade dnsimple client to 8.3.0#6372
weppos wants to merge 4 commits intokubernetes-sigs:masterfrom
weppos:upgrade-dnsimple-client-8.3.0

Conversation

@weppos
Copy link
Copy Markdown
Contributor

@weppos weppos commented Apr 16, 2026

What does it do ?

The current version uses a fairly old DNSimple client. This PR simply upgrades the client version, to take advantage of newer capabilities and better performance.

Motivation

Current version is 4+ old, it's running 7 major versions behind. No code changes were actually required, other the version bump.

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ivankatliarchuk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the provider Issues or PRs related to a provider label Apr 16, 2026
@k8s-ci-robot k8s-ci-robot requested review from szuecs and vflaux April 16, 2026 13:41
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 16, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @weppos. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 16, 2026
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 16, 2026
@weppos
Copy link
Copy Markdown
Contributor Author

weppos commented Apr 16, 2026

Fixed conflicts with master.

@vflaux
Copy link
Copy Markdown
Contributor

vflaux commented Apr 16, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 16, 2026
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 16, 2026

Coverage Report for CI Build 24824831243

Coverage increased (+0.005%) to 80.466%

Details

  • Coverage increased (+0.005%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 21373
Covered Lines: 17198
Line Coverage: 80.47%
Coverage Strength: 1466.98 hits per line

💛 - Coveralls

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 23, 2026
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 23, 2026
@weppos weppos changed the title Upgrade dnsimple client to 8.3.0 chore(deps): Upgrade dnsimple client to 8.3.0 Apr 23, 2026
@ivankatliarchuk
Copy link
Copy Markdown
Member

Could you share results similar to #5111 (comment). We need to make sure it still works

@weppos
Copy link
Copy Markdown
Contributor Author

weppos commented Apr 30, 2026

Could you share results similar to #5111 (comment). We need to make sure it still works

Hi @ivankatliarchuk, unfortunately I can't as I don't have a running instance to test against. I relied on the unit test present in this repo:

➜  external-dns git:(upgrade-dnsimple-client-8.3.0)  go test -race -v ./provider/dnsimple/...
=== RUN   TestDnsimpleServices
=== RUN   TestDnsimpleServices/Zones
=== RUN   TestDnsimpleServices/Records
=== RUN   TestDnsimpleServices/ApplyChanges
time="2026-04-30T11:07:17+02:00" level=info msg="Changing records: CREATE {0  0 CNAME example.example.com target 3600 0 false []  } in zone: example.com"
time="2026-04-30T11:07:17+02:00" level=info msg="Changing records: CREATE {0  0 CNAME custom-ttl.example.com target 60 0 false []  } in zone: example.com"
time="2026-04-30T11:07:17+02:00" level=info msg="Changing records: UPDATE {0  0 CNAME example.example.com target 3600 0 false []  } in zone: example.com"
time="2026-04-30T11:07:17+02:00" level=info msg="Changing records: UPDATE {0  0 A example.com 127.0.0.1 3600 0 false []  } in zone: example.com"
time="2026-04-30T11:07:17+02:00" level=info msg="Changing records: DELETE {0  0 A example-beta.example.com 127.0.0.1 3600 0 false []  } in zone: example.com"
=== RUN   TestDnsimpleServices/ApplyChanges/SkipUnknownZone
=== RUN   TestDnsimpleServices/SuitableZone
=== RUN   TestDnsimpleServices/GetRecordID
--- PASS: TestDnsimpleServices (0.01s)
    --- PASS: TestDnsimpleServices/Zones (0.00s)
    --- PASS: TestDnsimpleServices/Records (0.00s)
    --- PASS: TestDnsimpleServices/ApplyChanges (0.00s)
    --- PASS: TestDnsimpleServices/ApplyChanges/SkipUnknownZone (0.00s)
    --- PASS: TestDnsimpleServices/SuitableZone (0.00s)
    --- PASS: TestDnsimpleServices/GetRecordID (0.00s)
=== RUN   TestNewProvider
--- PASS: TestNewProvider (0.46s)
PASS
ok      sigs.k8s.io/external-dns/provider/dnsimple      2.175s

@ivankatliarchuk
Copy link
Copy Markdown
Member

no prolem. no rush here

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 30, 2026
@weppos
Copy link
Copy Markdown
Contributor Author

weppos commented Apr 30, 2026

I hope someone will be able to confirm. The client currently running is very hold, and we have retired certain endpoint and API attributes. It will actually stop working properly at some point if no upgrade is performed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. provider Issues or PRs related to a provider size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants