chore(deps): Upgrade dnsimple client to 8.3.0#6372
chore(deps): Upgrade dnsimple client to 8.3.0#6372weppos wants to merge 4 commits intokubernetes-sigs:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @weppos. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Fixed conflicts with master. |
|
/ok-to-test |
Coverage Report for CI Build 24824831243Coverage increased (+0.005%) to 80.466%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
# Conflicts: # go.mod
|
Could you share results similar to #5111 (comment). We need to make sure it still works |
Hi @ivankatliarchuk, unfortunately I can't as I don't have a running instance to test against. I relied on the unit test present in this repo: |
|
no prolem. no rush here /hold |
|
I hope someone will be able to confirm. The client currently running is very hold, and we have retired certain endpoint and API attributes. It will actually stop working properly at some point if no upgrade is performed. |
What does it do ?
The current version uses a fairly old DNSimple client. This PR simply upgrades the client version, to take advantage of newer capabilities and better performance.
Motivation
Current version is 4+ old, it's running 7 major versions behind. No code changes were actually required, other the version bump.
More