feat(source): set transformer on all informers#6451
Merged
Conversation
k8s-ci-robot
added
cncf-cla: yes
Coverage Report for CI Build 26724753323Coverage increased (+0.06%) to 80.691%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions323 previously-covered lines in 9 files lost coverage.
Coverage Stats
💛 - Coveralls |
mloiseleur
reviewed
May 22, 2026
Collaborator
|
/lgtm |
k8s-ci-robot
added
the
lgtm
ivankatliarchuk
suggested changes
May 25, 2026
ivankatliarchuk
left a comment
ivankatliarchuk
left a comment
Member
There was a problem hiding this comment.
Tests missing for added functionality
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
added
size/XL
Member
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Member
|
/lgtm cancel Found few things |
k8s-ci-robot
removed
the
lgtm
ivankatliarchuk
suggested changes
May 31, 2026
ivankatliarchuk
left a comment
ivankatliarchuk
left a comment
Member
There was a problem hiding this comment.
Persistent typo across the entire PR: Every function except one uses Tranform instead of Transform
Traefik test only covers 1 of 6 informers
Member
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ivankatliarchuk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do ?
Setup a transformer on all sources informers that removes kubectl last applied config annotation, managed fields and status condition (when it exists and is not needed).
Update
clearStatusConditions()to supportUnstructuredresources.Motivation
We need the transformer to support multiple annotation prefixes. Split from #6449 from easier review.
Should also minimize memory usage.
More