Skip to content

feat(source): add --fqdn-* flag support to traefik-proxy source#6468

Merged
k8s-ci-robot merged 3 commits into
kubernetes-sigs:masterfrom
gofogo:feat/traefik-source-fqdn-target-template
Jun 4, 2026
Merged

feat(source): add --fqdn-* flag support to traefik-proxy source#6468
k8s-ci-robot merged 3 commits into
kubernetes-sigs:masterfrom
gofogo:feat/traefik-source-fqdn-target-template

Conversation

@ivankatliarchuk

@ivankatliarchuk ivankatliarchuk commented Jun 3, 2026

Copy link
Copy Markdown
Member

What does it do ?

  • traefikSource now accepts a template.Engine (wired from cfg.TemplateEngine) and applies it to all three Traefik CRD types: IngressRoute, IngressRouteTCP, and IngressRouteUDP
  • Added endpointsFromTemplate (handles --fqdn-template + --target-template) and endpointsFromFQDNTargetTemplate (handles --fqdn-target-template with host:target pairs), following the identical pattern used by the unstructured source
  • Template combination uses the two-step CombineWithEndpoints flow: fqdn-target-template first, then fqdn+target-template — preserving existing rule/annotation-based endpoints when no combine flag is set

Motivation

  • The traefik-proxy source did not support DNS name generation via --fqdn-template, preventing users from deriving hostnames from resource metadata (name, namespace, labels) without using annotations
  • And added support of --target-template and --fqdn-target-template to make it possible to to override or derive DNS targets from resource metadata

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
@k8s-ci-robot k8s-ci-robot requested a review from mloiseleur June 3, 2026 17:40
@k8s-ci-robot k8s-ci-robot requested a review from u-kai June 3, 2026 17:40
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 3, 2026
@ivankatliarchuk ivankatliarchuk marked this pull request as draft June 3, 2026 17:43
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 3, 2026
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
@ivankatliarchuk ivankatliarchuk marked this pull request as ready for review June 3, 2026 17:51
@k8s-ci-robot k8s-ci-robot added docs and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jun 3, 2026
@k8s-ci-robot k8s-ci-robot requested a review from vflaux June 3, 2026 17:51
@coveralls

coveralls commented Jun 3, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 26903629979

Coverage decreased (-0.05%) to 80.646%

Details

  • Coverage decreased (-0.05%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 111 coverage regressions across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

111 previously-covered lines in 1 file lost coverage.

File Lines Losing Coverage Coverage
traefik_proxy.go 111 67.54%

Coverage Stats

Coverage Status
Relevant Lines: 21536
Covered Lines: 17368
Line Coverage: 80.65%
Coverage Strength: 1444.9 hits per line

💛 - Coveralls

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>

@mloiseleur mloiseleur left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 3, 2026
@ivankatliarchuk

Copy link
Copy Markdown
Member Author

/approve

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivankatliarchuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2026
@k8s-ci-robot k8s-ci-robot merged commit b808ffd into kubernetes-sigs:master Jun 4, 2026
21 checks passed
@ivankatliarchuk ivankatliarchuk deleted the feat/traefik-source-fqdn-target-template branch June 4, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. docs lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. source

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants