Skip to content

fix(registry/txt): create ownership TXT records before primary records #6582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Arkelenia wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(registry/txt): create ownership TXT records before primary records #6582

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion registry/txt/registry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,18 +363,24 @@ func (im *TXTRegistry) ApplyChanges(ctx context.Context, changes *plan.Changes)
Delete: endpoint.FilterEndpointsByOwnerID(im.ownerID, changes.Delete),
}

createTXTRecords := make([]*endpoint.Endpoint, 0, 2*len(filteredChanges.Create))
for _, r := range filteredChanges.Create {
if r.Labels == nil {
r.Labels = make(map[string]string)
}
r.Labels[endpoint.OwnerLabelKey] = im.ownerID

filteredChanges.Create = append(filteredChanges.Create, im.generateTXTRecordWithFilter(r, im.existingTXTs.isAbsent)...)
createTXTRecords = append(createTXTRecords, im.generateTXTRecordWithFilter(r, im.existingTXTs.isAbsent)...)

if im.cacheInterval > 0 {
im.addToCache(r)
}
}
// Ownership TXT records are created before their corresponding primary records so that,
// if a provider only partially applies this batch, the failure mode is an orphan TXT
// record (harmless, retried next sync) rather than a primary record with no TXT owner
// (which the registry then treats as unowned and stops reconciling forever).
filteredChanges.Create = append(createTXTRecords, filteredChanges.Create...)

for _, r := range filteredChanges.Delete {
// when we delete TXT records for which value has changed (due to new label) this would still work because
Expand Down