feat(gateway): decoupled DNS hostname from listener hostname via annotation-only - #6612
Conversation
…via annotation-only
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @cleman95! |
|
Hi @cleman95. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What does it do ?
When external-dns.kubernetes.io/gateway-hostname-source: annotation-only is set on a Route, ExternalDNS now creates DNS records from the annotation hostname (external-dns.kubernetes.io/hostname) using the parent Gateway's IP address, without requiring the annotation hostname to match the listener hostname.
Previously, matchRouteToListener required gwMatchingHost(listenerHostname, routeHostname) to return true before any endpoints were generated. When the annotation hostname differed from the listener hostname, the route was silently skipped, the gateway-hostname-source: annotation-only annotation was never effectively evaluated.
Motivation
Fixes #6594
The Ingress source already supports decoupling DNS hostname from routing hostname via external-dns.kubernetes.io/ingress-hostname-source: annotation-only, which creates a DNS record for any hostname in the annotation regardless of the Ingress spec host. The Gateway API source lacked this capability, making the following migration pattern impossible:
This pattern is common during Ingress → Gateway API migrations where the DNS zone managed by external-dns doesn't cover the routing hostname's parent zone, or where a CNAME chain exists between an externally-managed hostname and the RFC2136 zone.
More
The existing docs/sources/gateway-api.md already documents the gateway-hostname-source annotation. The behavior change (bypassing listener hostname matching in annotation-only mode) could be noted there. Let me know if you'd like me to update it.