Skip to content

Add benchmarking folder #1689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2025
Merged

Add benchmarking folder #1689

merged 1 commit into from
Nov 5, 2025
+1,053 −18

Conversation

@rlakhtakia
Copy link
Contributor

@rlakhtakia rlakhtakia commented Oct 7, 2025 •
edited
Loading

What type of PR is this?
/kind documentation

Does this PR introduce a user-facing change?:

NONE

#1688

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/documentation Categorizes issue or PR as related to documentation. labels Oct 7, 2025
@netlify
Copy link

netlify bot commented Oct 7, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 03d9418
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/690bc92509340800080367eb
😎 Deploy Preview https://deploy-preview-1689--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 7, 2025
@rlakhtakia rlakhtakia marked this pull request as draft October 7, 2025 16:21
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 7, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 7, 2025

Hi @rlakhtakia. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 7, 2025
@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 13, 2025
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 13, 2025
@rlakhtakia rlakhtakia changed the title [WIP] Add benchmarking folder with prefix cache aware set up Add benchmarking folder with prefix cache aware example set up Oct 13, 2025
@rlakhtakia rlakhtakia changed the title Add benchmarking folder with prefix cache aware example set up Add benchmarking folder Oct 13, 2025
@rlakhtakia rlakhtakia marked this pull request as ready for review October 13, 2025 17:02
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 13, 2025
@kfswain
Copy link
Collaborator

kfswain commented Oct 14, 2025

/ok-to-test

Thanks! Looks good!

Do you mind splitting this up a bit?
We can update the guides here.

And is this looks like a helm chart we are defining for benchmarking, which is great! Have we talked to the inference-perf folks to see if they want to use this?

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 14, 2025
kfswain
kfswain reviewed Oct 14, 2025
View reviewed changes
@kfswain kfswain mentioned this pull request Oct 14, 2025
Closed
liu-cong
liu-cong reviewed Oct 16, 2025
View reviewed changes
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2025
@danehans
Copy link
Contributor

danehans commented Oct 31, 2025

@rlakhtakia thanks for the contribution. Do you have any updates regarding #1689 (comment)?

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 5, 2025
@rlakhtakia rlakhtakia force-pushed the main branch 2 times, most recently from eeda363 to fad75e6 Compare November 5, 2025 00:30
@rlakhtakia
Copy link
Contributor Author

rlakhtakia commented Nov 5, 2025

Blocked until kubernetes-sigs/inference-perf#264.

@rlakhtakia
Copy link
Contributor Author

rlakhtakia commented Nov 5, 2025

@rlakhtakia thanks for the contribution. Do you have any updates regarding #1689 (comment)?

All should be updated however remote repo is still not available.

@rlakhtakia rlakhtakia force-pushed the main branch 2 times, most recently from 5859d89 to 2b5028b Compare November 5, 2025 01:12
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 5, 2025
@rlakhtakia
Copy link
Contributor Author

rlakhtakia commented Nov 5, 2025

Added a temp chart to not be blocked further on this. #1815 will track cleaning this up once the remote is available.

@rlakhtakia
Copy link
Contributor Author

rlakhtakia commented Nov 5, 2025

@liu-cong @kfswain @danehans ptal!

@kfswain
Copy link
Collaborator

kfswain commented Nov 5, 2025

/unhold
/approve

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 5, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kfswain, rlakhtakia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2025
@kfswain
Copy link
Collaborator

kfswain commented Nov 5, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2025
@kfswain
Copy link
Collaborator

kfswain commented Nov 5, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2025
@k8s-ci-robot k8s-ci-robot merged commit 95fd944 into kubernetes-sigs:main Nov 5, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kfswain kfswain kfswain left review comments

@danehans danehans Awaiting requested review from danehans

@elevran elevran Awaiting requested review from elevran

@nirrozenbaum nirrozenbaum Awaiting requested review from nirrozenbaum

+1 more reviewer

@liu-cong liu-cong liu-cong left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@liu-cong liu-cong

@kfswain kfswain

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rlakhtakia @k8s-ci-robot @kfswain @liu-cong @danehans