Add prompt_cached_tokens metrics from each response. #1814
Merged
+108
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
kind/feature
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
|
/assign @liu-cong |
|
/approve |
k8s-ci-robot
added
the
approved
liu-cong
reviewed
Nov 5, 2025
pkg/epp/metrics/metrics.go
Outdated
|
|
||
| // RecordPromptCachedTokens records prompt cached tokens count. | ||
| func RecordPromptCachedTokens(modelName, targetModelName string, size int) { | ||
| if size > 0 { |
There was a problem hiding this comment.
Why checking this? Isn't 0 a valid value?
There was a problem hiding this comment.
Good call, added emitting zero, please take another look.
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kfswain, liu-cong, zetxqx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR introduces a new histogram metric, inference_objective_prompt_cached_tokens, to provide visibility into the
effectiveness of the vLLM prefix caching feature.
The key changes include:
non-streaming and streaming responses. If the field is not present in a response, no metric is recorded for that request,
ensuring data accuracy
Which issue(s) this PR fixes:
Fixes partially #1304
Does this PR introduce a user-facing change?: