fix(inferenceModelRewrites): conditionally skip watching InferenceModelRewrite and InferenceObjective #1967
Conversation
k8s-ci-robot
added
kind/bug
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
size/L
zetxqx
force-pushed
the
skipconfig
branch
2 times, most recently
from
e264344 to
1c13110
Compare
|
This is another inferenceModelRewrites hardening PR. This will let both I tested this working well by deleting the |
zetxqx
changed the title
pkg/epp/server/controller_config.go
Outdated
| ) | ||
|
|
||
| type ControllerConfig struct { | ||
| disableK8sCrdReconcile bool |
There was a problem hiding this comment.
I would flip this from disable to enable semantic, also rename to startCrdReconcilers
There was a problem hiding this comment.
mostly to avoid cases like !disable, double negate is not a good pattern
ahg-g
left a comment
ahg-g
left a comment
There was a problem hiding this comment.
sounds good to me, left one nit, let me know if you agree
|
/approve |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
needs-rebase
|
needs a rebase unfortunately |
…enceObjective when disableK8sCrdReconcile is true This fixes an issue where the controller manager would fail to start if the InferenceModelRewrite or InferenceObjective CRDs were missing. This change introduces a dynamic check for the existence of these CRDs before attempting to set up reconcilers or adding them to the cache. This allows the controller to gracefully handle environments where these optional CRDs are not installed, even when CRD reconciliation is generally enabled. Refactoring: - Moved kindExists to pkg/epp/server/controller_manager.go - Updated kindExists signature to accept discovery.DiscoveryInterface - Reused discovery client in NewDefaultManager and ExtProcServerRunner.SetupWithManager to avoid repeated client creation overhead. Done by: gemini-cli TEST=go test ./pkg/epp/server/... passed
k8s-ci-robot
removed
the
needs-rebase
zetxqx
force-pushed
the
skipconfig
branch
2 times, most recently
from
59db1d2 to
ab7f4b4
Compare
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, zetxqx The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
What type of PR is this?
/kind bug
/kind cleanup
What this PR does / why we need it:
This fixes an issue where the controller manager would fail to start if the InferenceModelRewrite or InferenceObjective CRDs were missing. This change introduces a dynamic check for the existence of these CRDs before attempting to set up reconcilers or adding them to the cache. This allows the controller to gracefully handle environments where these optional CRDs are not installed, even when CRD reconciliation is generally enabled.
Tested with deleting the
inferenceModelRewrites CRDand start the EPP successfully.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: