Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new maintainers #203

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Conversation

robscott
Copy link
Member

This formally adds a set of maintainers that have already been actively leading this project. Once this is broadly approved and merged, we can mirror this in k/org to make it easier to release v0.1 of the API.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 16, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 16, 2025
Copy link

netlify bot commented Jan 16, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit f5eeb15
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/67898013ab3c9d000875149b
😎 Deploy Preview https://deploy-preview-203--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jan 16, 2025
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 16, 2025
@k8s-ci-robot
Copy link
Contributor

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the kubernetes-sigs org. You can then trigger verification by writing /verify-owners in a comment.

  • gateway-api-inference-extension-reviewers
    • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.
  • gateway-api-inference-extension-maintainers
    • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.
    • OWNERS
  • wg-serving-leads
    • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.

@robscott
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2025
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2025
@ahg-g
Copy link
Contributor

ahg-g commented Jan 20, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2025
@kfswain
Copy link
Collaborator

kfswain commented Jan 21, 2025

/lgtm

@danehans
Copy link
Contributor

Thank you all for your trust and consideration. I've enjoyed contributing to the project and am excited to collaborate further as a maintainer. I look forward to continuing to build and improve together!

/lgtm

@terrytangyuan
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2025
@terrytangyuan terrytangyuan merged commit 26d2765 into kubernetes-sigs:main Jan 21, 2025
7 of 8 checks passed
@@ -0,0 +1,18 @@
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://go.k8s.io/owners is a more convenient link

anyhow, this is incorrectly formatted, these need to be under an aliases: top level key.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 thanks for catching this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants