-
Notifications
You must be signed in to change notification settings - Fork 635
build(deps): update dependabot config, bump sigs.k8s.io/controller-runtime from 0.22.3 to 0.22.4 in /conformance and /tests #4356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dependabot/go_modules/conformance/sigs.k8s.io/controller-runtime-0.22.4
Are you sure you want to change the base?
Conversation
|
/release-note-none |
|
yeah, it should be bumping on both directories. This is some dependabot weirdness, it has some issues with go workspaces (from last time I saw it). I will take a look later if there's something that it should be doing and it is not /lgtm Thanks! |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mikemorris, rikatz The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
ah wait, should the bump also contain "sigs.k8s.io" as a pattern? like gateway-api/.github/dependabot.yml Line 15 in c448aed
|
Ah, that's why it worked as expected for #4353! |
|
Added a commit to include |
|
/lgtm |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
#4289 has failing
git diffbecause it only bumps thecontroller-runtimedep in/conformanceand nottests@rikatz it looks like the Dependabot config in
gateway-api/.github/dependabot.yml
Lines 7 to 8 in c448aed
go work syncdoes expect it.Which issue(s) this PR fixes:
Fixes #4289
Does this PR introduce a user-facing change?: