Align GRPCRoute hostname cross-serving godoc with the relaxed site docs - #5176
Align GRPCRoute hostname cross-serving godoc with the relaxed site docs#5176lexfrei wants to merge 1 commit into
Conversation
The site docs no longer require implementations to reject a GRPCRoute whose hostnames intersect an HTTPRoute on the same listener; enforcing uniqueness is optional. The GRPCRouteSpec.Hostnames godoc still stated the old MUST, and that text is what the generated CRD descriptions and API reference carry. Update the godoc and regenerate. Signed-off-by: Aleksei Sviridkin <f@lex.la>
|
Hi @lexfrei. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lexfrei The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/ok-to-test |
|
This is a two-line godoc alignment with the site docs; CI is green since the ok-to-test. Anything needed from my side? |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
#4598 relaxed the cross-serving rule on the site page: implementations may enforce hostname uniqueness between GRPCRoute and HTTPRoute, they no longer must. The
GRPCRouteSpec.Hostnamesgodoc still says MUST, and that text is what ends up in the CRD descriptions and the API reference. This changes the godoc to match and regenerates.Left alone on purpose: GEP-1016 still carries the old wording, and the "When to Use GRPCRoute" section of the site page still says to use HTTPRoute for both when sharing a hostname. I can fold either in if you want them here.
This PR was written in part with the assistance of generative AI.
Which issue(s) this PR fixes:
None
Does this PR introduce a user-facing change?:
AI disclosure
This PR was prepared with AIL:3. I personally reviewed each line of the submission prior to opening this PR.