conformance: validate Implementation.URL is a well-formed http(s) URL - #5209
conformance: validate Implementation.URL is a well-formed http(s) URL#5209yashrajshuklaaa wants to merge 1 commit into
Conversation
Signed-off-by: Yashraj Shukla <shuklayashraj68@gmail.com>
|
Hi @yashrajshuklaaa. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| { | ||
| name: "empty contact", | ||
| mutate: func(i Implementation) Implementation { | ||
| i.Contact = nil |
There was a problem hiding this comment.
Likely worth testing []string{} as well
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott, yashrajshuklaaa The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
/kind feature
/area conformance-machinery
Adds URL validation to
Implementation.Validate(). It checked required fields were non-empty but never checked the URL was actually valid.