Skip to content

do not count user errors 409 already exists errors against SLO#1298

Open
mansisampat wants to merge 1 commit into
kubernetes-sigs:masterfrom
mansisampat:already-exists
Open

do not count user errors 409 already exists errors against SLO#1298
mansisampat wants to merge 1 commit into
kubernetes-sigs:masterfrom
mansisampat:already-exists

Conversation

@mansisampat

Copy link
Copy Markdown

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

We saw unhappy cluster with error -

GRPC call: /csi.v1.Controller/CreateVolume, GRPC error: rpc error: code = Internal desc = googleapi: Error 409: Resource 'projects/...locations/us-east4-b/instances/...' already exists

Currently the AlreadyExists maps to Internal Error and hence results in SLO Violations. We are updating the mapping to UserError.

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label May 20, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mansisampat
Once this PR has been reviewed and has the lgtm label, please assign savirg for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@linux-foundation-easycla

Copy link
Copy Markdown

CLA Not Signed

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Welcome @mansisampat!

It looks like this is your first PR to kubernetes-sigs/gcp-filestore-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gcp-filestore-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 20, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Hi @mansisampat. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants