Skip to content

[WIP] Add support for Filestore Share Pools volume provisioning [WIP]#1312

Open
ayushi-gupta wants to merge 1 commit into
kubernetes-sigs:masterfrom
ayushi-gupta:feature/csi-sharepools-integration
Open

[WIP] Add support for Filestore Share Pools volume provisioning [WIP]#1312
ayushi-gupta wants to merge 1 commit into
kubernetes-sigs:masterfrom
ayushi-gupta:feature/csi-sharepools-integration

Conversation

@ayushi-gupta

Copy link
Copy Markdown
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
This PR introduces support for Filestore Share Pools dynamic volume provisioning and deletion inside the GCP Filestore CSI Driver:

  • Share Pools Provisioning Handler: Adds handleCreateSharePoolVolume and handleDeleteSharePoolVolume in the controller manager (pkg/csi_driver/controller.go) to detect and route volume requests referencing the sharepool StorageClass parameter.
  • GCFS Client Wrapper: Integrates the official ProjectsLocationsSharePoolsService API clients inside pkg/cloud_provider/file/file.go to handle AcquireShare and ReleaseShare service calls.
  • Composite VolumeID Contracts: Establishes sharepool://{project}/{location}/{share_pool}/shares/{uuid}?ip={ip_address} as the standardized composite VolumeID schema for tracking and releasing provisioned shares.
  • Unit Testing: Introduces comprehensive tests in pkg/csi_driver/controller_test.go covering success cases, idempotent retries, defaulting capacity behaviors, and malformed VolumeID validation checks.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

  • Vendored Dependency: This PR updates and references the Google API client library containing the generated SharePools bindings. A temporary replace directive is added in go.mod pointing to ./third_party/google.golang.org/api because the updated API client library version has not yet been officially released on the public internet. This should be updated once the library is published.

Does this PR introduce a user-facing change?:

**TBA**

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jun 8, 2026
@linux-foundation-easycla

Copy link
Copy Markdown

CLA Not Signed

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 8, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Welcome @ayushi-gupta!

It looks like this is your first PR to kubernetes-sigs/gcp-filestore-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gcp-filestore-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 8, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Hi @ayushi-gupta. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ayushi-gupta
Once this PR has been reviewed and has the lgtm label, please assign saikat-royc for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants