frontend: Render links for CR's columns that point to k8s resources #2482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes render any references that look like k8s kinds as links to their details page in Headlamp. Based on an initial patch by: guilhane <[email protected]> Signed-off-by: Joaquim Rocha <[email protected]>
dosubot
bot
added
the
size:M
|
Thanks @joaquimrocha for your work on this feature ! It's hard for me to provide feedback without a more concrete example where this PR would be wrong. Would you be able to detail such a scenario ? |
|
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-contributor-experience at kubernetes/community. /check-cla |
|
k8s-ci-robot
added
the
cncf-cla: no
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes render any references that look like k8s kinds as links to their details page in Headlamp.
Based on #2278 .
@gberche-orange , this new PR actually shows the links to a resource's details view for any columns that look like they match a K8s kind. However, implementing this made me think whether this enough a common use-case. E.g. we may have an implementation of a CRD that has an additional printer col that may mention a secret/configmap/pod and another col that mentions this pod's namespace, different from the CR's for some reason... And this code would be wrong in that case.
So I wonder if this should rather be part of a plugin instead of being in the core.
cc/ @illume for getting your opinion too.