-
Notifications
You must be signed in to change notification settings - Fork 279
headlamp-build: Add package.json with scripts from Makefile #2573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
nice! since this is just a beginning I'd like to suggest a convention for package script names which I've seen in other projects
another suggestion is to use also I'm not sure if it's just me but I'd like to avoid duplicated commands like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it was simpler but I think we need to rethink what the scripts should be called rather than having a match to the make targets we had before.
docs/development/backend.md
Outdated
@@ -18,33 +18,33 @@ redirects the requests to the defined proxies. | |||
The backend (Headlamp's server) can be quickly built using: | |||
|
|||
```bash | |||
make backend | |||
npm run backend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the run backend
, even though matching what we had is more confusing, since this is not running backend but building it. Maybe npm run build:backend
and npm run backend
would actually try to run the backend. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will change npm run backend
so it runs the backend. So it is the same as npm run backend-run
. Same thing with npm run frontend
.
I don't think npm run build:backend
is a good idea to do or discuss now.
This is to simplify using Headlamp so that people do not need to have installed gnu Make. Which isn't on Windows, and isn't on some Mac/unix systems. Just starting with the start script, the rest can come later. This package is not intended to be published, and so the name is not important at this stage. Signed-off-by: René Dudfield <[email protected]>
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-contributor-experience at kubernetes/community. /check-cla |
This is to simplify using Headlamp so that people do not need to have gnu Make installed. Which isn't on Windows, and isn't on some Mac/unix systems.
Only has the start command t
Note: This package is not intended to be published, and so the name is not important at this stage.
npm start
works in root assuming you have node and golang installed