frontend: Add feature to view deploy/rs/ds logs#2581
Merged
joaquimrocha merged 1 commit intomainfrom Feb 21, 2025
Merged
Conversation
dosubot
bot
added
the
size:L
knrt10
force-pushed
the
multi-pods-logs
branch
from
d9de25c to
d542f04
Compare
Member
Author
|
So weird, I ran the tests locally, updated snapshots, wonder why it is still failing 🤔 |
Member
Author
|
Changing some UX for this |
knrt10
force-pushed
the
multi-pods-logs
branch
from
d542f04 to
b2cf8f3
Compare
dosubot
bot
added
size:XL
Member
Author
|
Updated, please review |
knrt10
force-pushed
the
multi-pods-logs
branch
3 times, most recently
from
46a12fb to
7daec5f
Compare
knrt10
force-pushed
the
multi-pods-logs
branch
2 times, most recently
from
7848c4f to
016f070
Compare
Contributor
There was a problem hiding this comment.
Copilot reviewed 41 out of 57 changed files in this pull request and generated no comments.
Files not reviewed (16)
- frontend/src/components/common/Resource/MainInfoSection/snapshots/MainInfoSection.Normal.stories.storyshot: Language not supported
- frontend/src/components/common/Resource/MainInfoSection/snapshots/MainInfoSection.NullBacklink.stories.storyshot: Language not supported
- frontend/src/components/configmap/snapshots/Details.Empty.stories.storyshot: Language not supported
- frontend/src/components/configmap/snapshots/Details.WithBase.stories.storyshot: Language not supported
- frontend/src/components/crd/snapshots/CustomResourceDefinition.Details.stories.storyshot: Language not supported
- frontend/src/components/crd/snapshots/CustomResourceDetails.NoError.stories.storyshot: Language not supported
- frontend/src/components/cronjob/snapshots/CronJobDetails.EveryAst.stories.storyshot: Language not supported
- frontend/src/components/cronjob/snapshots/CronJobDetails.EveryMinute.stories.storyshot: Language not supported
- frontend/src/components/endpoints/snapshots/EndpointDetails.Default.stories.storyshot: Language not supported
- frontend/src/components/endpoints/snapshots/EndpointDetails.Error.stories.storyshot: Language not supported
- frontend/src/components/horizontalPodAutoscaler/snapshots/HPADetails.Default.stories.storyshot: Language not supported
- frontend/src/components/horizontalPodAutoscaler/snapshots/HPADetails.Error.stories.storyshot: Language not supported
- frontend/src/components/ingress/snapshots/ClassDetails.Basic.stories.storyshot: Language not supported
- frontend/src/components/ingress/snapshots/ClassDetails.WithDefault.stories.storyshot: Language not supported
- frontend/src/components/ingress/snapshots/Details.WithResource.stories.storyshot: Language not supported
- frontend/src/components/ingress/snapshots/Details.WithTLS.stories.storyshot: Language not supported
illume
force-pushed
the
multi-pods-logs
branch
from
016f070 to
bbf2d1c
Compare
illume
reviewed
Jan 3, 2025
Contributor
There was a problem hiding this comment.
I think this will be a very useful feature for people. It's very often the case I've personally wanted to look at all the logs in a deployment rather than ones from just one pod.
I think the error states could be added for if any request fails. Left a couple of notes in the spots I think they could be handled.
Maybe not in this PR... but it would probably good to add a loading state? I'm not sure if the logs already have a loading state? (I didn't look).
Adding some states into a LogsButton.stories.tsx would be nice to have.
illume
reviewed
Jan 3, 2025
illume
reviewed
Jan 3, 2025
knrt10
force-pushed
the
multi-pods-logs
branch
from
bbf2d1c to
b8779b6
Compare
Member
Author
|
Updated the PR, please review |
Member
Author
I checked and can confirm that there isn't currently any loading state implemented for the logs
You're right - it would be good to add loading states for:
But I guess we can do it in a separate PR. WDYT? |
knrt10
force-pushed
the
multi-pods-logs
branch
2 times, most recently
from
d8e8756 to
ae23695
Compare
joaquimrocha
force-pushed
the
multi-pods-logs
branch
from
ae23695 to
84766c1
Compare
joaquimrocha
requested changes
Jan 22, 2025
frontend/src/components/common/Resource/MainInfoSection/MainInfoSectionHeader.tsx
Outdated
Show resolved
Hide resolved
knrt10
changed the title
knrt10
force-pushed
the
multi-pods-logs
branch
from
84766c1 to
7eb9a87
Compare
knrt10
force-pushed
the
multi-pods-logs
branch
3 times, most recently
from
b88a765 to
0cff437
Compare
This adds feature to view all the pods of pods in deploy, replicaSet, daemonSet rather than a specific pod. Fixes: #2552 Signed-off-by: Kautilya Tripathi <ktripathi@microsoft.com>
joaquimrocha
force-pushed
the
multi-pods-logs
branch
from
0cff437 to
d2c216a
Compare
joaquimrocha
approved these changes
Feb 21, 2025
dosubot
bot
added
the
lgtm
Contributor
|
Nice work. I think we can iterate later to add things like showing all containers' logs too. |
illume
added
kind/feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds feature to view all the pods of pods in a deployment/ReplicaSet/DaemonSet rather than going to a specific pod.
Fixes: #2552
Testing
kubectl create deployment nginx --image=nginx --replicas=3Screenshots