Skip to content

frontend: KubeObject: Refactor getAuthorization logic #2654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joaquimrocha merged 2 commits into from
Jan 7, 2025
Merged

frontend: KubeObject: Refactor getAuthorization logic #2654

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25834ad
frontend: KubeObject: Use apiName for resource name
skoeva Dec 16, 2024
cf5b206
frontend: KubeObject: Refactor getAuthorization logic
skoeva Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 7 additions & 19 deletions frontend/src/lib/k8s/KubeObject.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,36 +508,24 @@ export class KubeObject<T extends KubeObjectInterface | KubeEvent = any> {
};

if (!resourceAttrs.resource) {
resourceAttrs['resource'] = this.pluralName;
resourceAttrs['resource'] = this.apiName;
}

// @todo: We should get the API info from the API endpoint.

// If we already have the group, version, and resource, then we can make the request
// without trying the API info, which may have several versions and thus be less optimal.
// If we already have the group and version, then we can make the request without
// trying the API info, which may have several versions and thus be less optimal.
if (!!resourceAttrs.group && !!resourceAttrs.version && !!resourceAttrs.resource) {
return this.fetchAuthorization(resourceAttrs);
}

// If we don't have the group, version, and resource, then we have to try all of the
// If we don't have the group or version, then we have to try all of the
// API info versions until we find one that works.
const apiInfo = this.apiEndpoint.apiInfo;
for (let i = 0; i < apiInfo.length; i++) {
const { group, version, resource } = apiInfo[i];
// We only take from the details from the apiInfo if they're missing from the resourceAttrs.
// The idea is that, since this function may also be called from the instance's getAuthorization,
// it may already have the details from the instance's API version.
const attrs = { ...resourceAttrs };

if (!!attrs.resource) {
attrs.resource = resource;
}
if (!!attrs.group) {
attrs.group = group;
}
if (!!attrs.version) {
attrs.version = version;
}
const { group, version } = apiInfo[i];
// The group and version are tied, so we take both if one is missing.
const attrs = { ...resourceAttrs, group: group, version: version };

let authResult;

Expand Down
Loading