Skip to content

frontend: Add CssBaseline component for improved default styles#2680

Merged
joaquimrocha merged 1 commit intomainfrom
baseline-styles
Dec 19, 2024
Merged

frontend: Add CssBaseline component for improved default styles#2680
joaquimrocha merged 1 commit intomainfrom
baseline-styles

Conversation

@sniok
Copy link
Contributor

@sniok sniok commented Dec 13, 2024

It's a "css reset" that comes from mui library.

Makes scrollbars match the theme for example.

Before

image

After

image

@sniok sniok added kind/feature Categorizes issue or PR as related to a new feature. frontend Issues related to the frontend labels Dec 13, 2024
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 13, 2024
@sniok sniok requested a review from a team December 13, 2024 11:00
Copy link
Contributor

@skoeva skoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sniok sniok marked this pull request as draft December 13, 2024 16:05
@sniok
Copy link
Contributor Author

sniok commented Dec 13, 2024

Didn't notice that we already have CssBaseline in Layout.tsx, I'll update the property there

… default styles

Signed-off-by: Oleksandr Dubenko <oldubenko@microsoft.com>
@sniok sniok marked this pull request as ready for review December 16, 2024 08:59
@dosubot dosubot bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 19, 2024
@joaquimrocha joaquimrocha merged commit b62a424 into main Dec 19, 2024
14 checks passed
@joaquimrocha joaquimrocha deleted the baseline-styles branch December 19, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Issues related to the frontend kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants