Skip to content

frontend: Fix useKubeObjectLists when deselecting namespaces#2697

Merged
joaquimrocha merged 1 commit intomainfrom
watching-namespaces-fix
Dec 20, 2024
Merged

frontend: Fix useKubeObjectLists when deselecting namespaces#2697
joaquimrocha merged 1 commit intomainfrom
watching-namespaces-fix

Conversation

@sniok
Copy link
Contributor

@sniok sniok commented Dec 16, 2024

Found a bug with useKubeObjectLists when selecting fewer namespaces than before

Steps to reproduce

  1. Go to Pods
  2. Select at least 2 namespaces
  3. Observe correct amount of websocket connections (same as amount of namespaces)
  4. Deselect some namespaces
  5. More websocket connections are recreated than needed

Signed-off-by: Oleksandr Dubenko <oldubenko@microsoft.com>
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 16, 2024
@sniok sniok requested a review from a team December 17, 2024 09:57
@dosubot dosubot bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2024
@joaquimrocha joaquimrocha merged commit e069d3f into main Dec 20, 2024
14 checks passed
@joaquimrocha joaquimrocha deleted the watching-namespaces-fix branch December 20, 2024 18:38
@joaquimrocha joaquimrocha added this to the v0.28.0 milestone Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm "Looks good to me", indicates that a PR is ready to be merged. size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants