Frontend: Settings: refactor and test Rename Cluster #2871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Faakhir30 <[email protected]>
Signed-off-by: Faakhir30 <[email protected]>
Signed-off-by: Faakhir30 <[email protected]>
Signed-off-by: Faakhir30 <[email protected]>
Faakhir30
force-pushed
the
test_rename_settings
branch
from
ff73cc9 to
b6b6fa9
Compare
dosubot
bot
added
the
size:XL
|
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-contributor-experience at kubernetes/community. /check-cla |
k8s-ci-robot
added
cncf-cla: yes
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2198
Tasks Done:
updateStatelessClusterKubeconfig.Some observations:
(might need confirmation from maintainers)
electronenvironments, therefore I've added e2e-test toappdir.Enterinstead of clickingApply, there is no confirmation dialog/modal opening, directly cluster name is updated and Page reloads sucessfully.