Skip to content

frontend: Add e2e-tests for react-hotkeys dependency #2966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

frontend: Add e2e-tests for react-hotkeys dependency #2966

wants to merge 1 commit into from

Conversation

adwait-godbole
Copy link
Contributor

Fixes #2380

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Mar 1, 2025
@adwait-godbole
Copy link
Contributor Author

adwait-godbole commented Mar 1, 2025 •
edited
Loading

I have noticed here that on the below page,

Screenshot from 2025-02-18 09-17-41

the cluster-chooser hotkey code over here:

https://github.com/headlamp-k8s/headlamp/blob/main/frontend/src/components/cluster/Chooser.tsx#L54-#L60

is not working when headlamp is deployed with all the additional plugins but clicking on the button manually is opening the popup.

(This is not the case when headlamp is deployed without any additional plugins. Without any additional plugins, the hotkey is working as expected and opening the cluster chooser popup without any manual intervention)

@adwait-godbole adwait-godbole force-pushed the feat/test-react-hotkeys branch from 21ae759 to 25ab237 Compare March 1, 2025 11:12
skoeva
skoeva reviewed Mar 20, 2025
View reviewed changes
Copy link
Contributor

@skoeva skoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you looked at debugging the multi-cluster test? seems to be failing the CI

@adwait-godbole
Copy link
Contributor Author

adwait-godbole commented Mar 21, 2025 •
edited
Loading

Have you looked at debugging the multi-cluster test? seems to be failing the CI

Hi @skoeva, the test is failing due to the same reason that I have mentioned in the this comment.

@k8s-triage-robot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla
/easycla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 1, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skoeva skoeva skoeva left review comments

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add test(s) for react-hotkeys dependency
4 participants
@adwait-godbole @k8s-triage-robot @k8s-ci-robot @skoeva