Add a way to manage external tools' binaries #2985
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XXL
joaquimrocha
force-pushed
the
command-management
branch
from
5ed7283 to
ba6a7bf
Compare
|
We need to bundle minikube, because air-gapped. |
joaquimrocha
force-pushed
the
command-management
branch
from
ba6a7bf to
a32d050
Compare
Desktop only. Signed-off-by: Joaquim Rocha <[email protected]>
External binaries may be needed for some plugins to work, or for the user's convenience. So this commit adds a way for the plugins to request such binaries and checks whether the user agrees. Signed-off-by: Joaquim Rocha <[email protected]>
Signed-off-by: Joaquim Rocha <[email protected]>
joaquimrocha
force-pushed
the
command-management
branch
from
a32d050 to
da4a582
Compare
sniok
reviewed
Mar 25, 2025
| win: { | ||
| x64: { | ||
| url: 'https://github.com/kubernetes/minikube/releases/download/{version}/minikube-windows-amd64.exe', | ||
| checksum: '25650839f34526ee0f85fd4faa2d5b327f6127caac3de82e1f905adc3aad29df', |
There was a problem hiding this comment.
checksum failed for me, checked in the release page and the checksum for this file is
d4060da824524df744ba85fa91394cabfab15f110c03b1d8b7f1d309116fed15
There was a problem hiding this comment.
Maybe I messed up copying the binaries, or AI got in the way 😛
Please update as appropriate.
|
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-contributor-experience at kubernetes/community. /check-cla |
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
cncf-cla: yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since using external tools like minikube, kubectl, etc. is becoming more and more important, we need a way for the user to actually download/manage those external dependencies, and for plugins to request them too.
This PR adds a new settings section "External Tools" which shows minikube + kubectl for now, whether they have been installed by Headlamp or found in the system and also ways to download/remove them.
It also adds a new example plugin which runs minikube status or informs the user when it needs consent, etc. in its plugin settings.
The code needs to be thoroughly reviewed.