app: backend: Add flag for watching plugins changes #3160
+27
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change creates a CLI flag in the backend + desktop for watching changes to the plugins or their directory. Stops watching for plugin changes in the container image. Signed-off-by: Evangelos Skopelitis <[email protected]> Signed-off-by: René Dudfield <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: skoeva The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/S
skoeva
force-pushed
the
plugins-watch-option-2
branch
from
f23870c to
6db08a2
Compare
k8s-ci-robot
added
size/M
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change creates a CLI flag in the backend + desktop for watching changes to the plugins or their directory.
Fixes: #2894, follow-up from #2939
Testing
Backend
make backendcd backend && ./headlamp-server -watch-plugins-changes falseDesktop
cd app && npm run buildcd dist/linux-unpacked && ./headlamp -watch-plugins-changes falseand ensure that the flag is passed in