Skip to content

frontend: Hide row actions with hidden columns #3201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

skoeva
Copy link
Collaborator

@skoeva skoeva commented May 2, 2025

This change ensures that when all of the non-action columns are hidden, the action column is also hidden.

Fixes: #2932, follow-up from #2968

Testing

  • Navigate to the Headlamp home page
  • Manually hide all the cluster fields in the table
  • Ensure that the row actions are also hidden
  • Manually unhide one field and ensure that the row actions appear again

@skoeva skoeva added kind/bug Categorizes issue or PR as related to a bug. frontend Issues related to the frontend labels May 2, 2025
@skoeva skoeva requested a review from illume May 2, 2025 15:20
@skoeva skoeva self-assigned this May 2, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 2, 2025
@k8s-ci-robot k8s-ci-robot requested a review from sniok May 2, 2025 15:20
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: skoeva
Once this PR has been reviewed and has the lgtm label, please assign joaquimrocha for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. frontend Issues related to the frontend kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clusters list table is visible even if all properties are hidden
2 participants