Skip to content

frontend: Add hostIPs and podIPs to pod#3241

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
ashu8912:add-host-and-pod-ips
Jul 10, 2025
Merged

frontend: Add hostIPs and podIPs to pod#3241
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
ashu8912:add-host-and-pod-ips

Conversation

@ashu8912
Copy link
Member

In the pod Details view some pods could have multiple host and pod IPs so when rendering the pod Details view we should show these IPs as well.
fixes #3083

@k8s-ci-robot k8s-ci-robot requested review from sniok and yolossn May 15, 2025 10:08
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 15, 2025
@ashu8912 ashu8912 force-pushed the add-host-and-pod-ips branch 2 times, most recently from 560359b to 7478f4d Compare May 19, 2025 05:24
@sniok
Copy link
Contributor

sniok commented May 19, 2025

After this change it shows both values, maybe we should hide plural version if it's the same as singular? (In this case for example only show HostIP and Pod IP, hide Host IPs and Pod IPs, because they're the same)

image

Copy link
Contributor

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashu8912 please see note by @sniok

@ashu8912 ashu8912 force-pushed the add-host-and-pod-ips branch from 7478f4d to fe7756a Compare May 27, 2025 07:18
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 27, 2025
@ashu8912 ashu8912 force-pushed the add-host-and-pod-ips branch from fe7756a to 453cd7b Compare May 27, 2025 07:55
@ashu8912 ashu8912 requested review from illume and sniok May 27, 2025 07:57
@ashu8912 ashu8912 force-pushed the add-host-and-pod-ips branch from 453cd7b to 968ad9b Compare July 7, 2025 14:40
@ashu8912 ashu8912 force-pushed the add-host-and-pod-ips branch from 968ad9b to 5aa3626 Compare July 10, 2025 17:17
@joaquimrocha
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashu8912, joaquimrocha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2025
@k8s-ci-robot k8s-ci-robot merged commit 635d8fa into kubernetes-sigs:main Jul 10, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

Development

Successfully merging this pull request may close these issues.

Show pod ip's instead of single ip when cluster is in dualstack mode

5 participants