-
Notifications
You must be signed in to change notification settings - Fork 489
Add Hindi language support #3248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hindi language support #3248
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fromsaurav The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Thanks. Can you please confirm if you used machine translation? It seems the structures generated are different to the ones we're using. Please see other files to see the structure. The Kubernetes and other jargon words are often not translated, because there are no good translations that make sense. Please consider if words like Kubernetes, and Pods are accurate? Can you please check the Kubernetes docs to see if they use the same ones? https://kubernetes.io/hi/docs/home/ |
|
Thank you for reviewing, I didn't use machine translation for this work. I manually translated the content, focusing on making it natural and understandable to hindi speakers, i'll update the pr with fixing the consistency of technical words with docs and other issues suggested, Would you be able to share an example of a specific structural difference you noticed, so I can make sure I address it correctly? |
|
Nice one, thank you.
I must be mistaken. I thought the error was caused by nested json. Please ignore this comment. |
@illume Thanks for the update! When i thought to take a look again for updation , i noticed there is much scope in making this fixing better, I've made all the suggested changes, keeping technical terms consistent with the Kubernetes docs. The structure now matches the other language files while maintaining natural Hindi phrasing throughout. Also reduced the PR size significantly with better output. |
…f other language translations
|
Thanks @fromsaurav We will have to wait for someone else who knows Hindi to review this. Will try and find someone on Monday. Cheers! |
Yeah surely, thanks! |
|
Oh by the way... We follow a linux kernel style of commit messages. With the context at the front followed by an action word and the rest.
|
oh sorry, my bad ! I'm fine with you squashing the commits during the merge process in the same linux kernel style. Thank you for the update! |
|
Thank you @fromsaurav ! |
Description
This PR adds support for Hindi language to HeadLamp. Hindi is one of the most widely spoken languages in the world, particularly in India, and this addition will make HeadLamp more accessible to Hindi-speaking users.
Changes
config.tsThe translation files include commonly used UI elements, Kubernetes terminology, and general application text translated to Hindi.
Fixes #3244

Refer the attachment for demo of changes