Skip to content

Conversation

@fromsaurav
Copy link
Contributor

Description

This PR adds support for Hindi language to HeadLamp. Hindi is one of the most widely spoken languages in the world, particularly in India, and this addition will make HeadLamp more accessible to Hindi-speaking users.

Changes

  • Added Hindi to the list of supported languages in config.ts
  • Created Hindi translation files for:
    • app.json
    • glossary.json
    • translation.json

The translation files include commonly used UI elements, Kubernetes terminology, and general application text translated to Hindi.

Fixes #3244
Refer the attachment for demo of changes
Screenshot from 2025-05-15 19-02-50

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 15, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fromsaurav
Once this PR has been reviewed and has the lgtm label, please assign sniok for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 15, 2025
@fromsaurav fromsaurav changed the title i18n: Add Hindi language support i18n: Added Hindi language support May 15, 2025
@illume
Copy link
Contributor

illume commented May 16, 2025

Thanks.

Can you please confirm if you used machine translation?

It seems the structures generated are different to the ones we're using. Please see other files to see the structure.

The Kubernetes and other jargon words are often not translated, because there are no good translations that make sense. Please consider if words like Kubernetes, and Pods are accurate? Can you please check the Kubernetes docs to see if they use the same ones? https://kubernetes.io/hi/docs/home/

@fromsaurav
Copy link
Contributor Author

Thank you for reviewing,

I didn't use machine translation for this work. I manually translated the content, focusing on making it natural and understandable to hindi speakers,
I'll adjust the translation files to match the existing structure used in other language files.
For Kubernetes terminology, I've checked the documentation as you suggested. I'll follow their approach of keeping technical terms like "Kubernetes" and "Pods" untranslated where appropriate, for consistency with the docs.

i'll update the pr with fixing the consistency of technical words with docs and other issues suggested,

Would you be able to share an example of a specific structural difference you noticed, so I can make sure I address it correctly?

@illume
Copy link
Contributor

illume commented May 16, 2025

Nice one, thank you.

i'll update the pr with fixing the consistency of technical words with docs and other issues suggested,

Would you be able to share an example of a specific structural difference you noticed, so I can make sure I address it correctly?

I must be mistaken. I thought the error was caused by nested json. Please ignore this comment.

@fromsaurav
Copy link
Contributor Author

fromsaurav commented May 16, 2025

Nice one, thank you.

i'll update the pr with fixing the consistency of technical words with docs and other issues suggested,
Would you be able to share an example of a specific structural difference you noticed, so I can make sure I address it correctly?

I must be mistaken. I thought the error was caused by nested json. Please ignore this comment.

@illume Thanks for the update! When i thought to take a look again for updation , i noticed there is much scope in making this fixing better, I've made all the suggested changes, keeping technical terms consistent with the Kubernetes docs. The structure now matches the other language files while maintaining natural Hindi phrasing throughout. Also reduced the PR size significantly with better output.
Pushing the changes, Thank You !

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 16, 2025
@fromsaurav fromsaurav changed the title i18n: Added Hindi language support i18n: Add Hindi language support May 17, 2025
@illume
Copy link
Contributor

illume commented May 17, 2025

Thanks @fromsaurav

We will have to wait for someone else who knows Hindi to review this. Will try and find someone on Monday.

Cheers!

@fromsaurav
Copy link
Contributor Author

Thanks @fromsaurav

We will have to wait for someone else who knows Hindi to review this. Will try and find someone on Monday.

Cheers!

Yeah surely, thanks!

@fromsaurav fromsaurav changed the title i18n: Add Hindi language support Add Hindi language support May 18, 2025
@illume
Copy link
Contributor

illume commented May 18, 2025

Oh by the way...

We follow a linux kernel style of commit messages. With the context at the front followed by an action word and the rest.
Would you mind changing the commit to something like this? It would be a good idea to squash the commit into one commit (but we can also do that at the end before we merge if you prefer).

frontend: app: i18n: Add Hindi language

@fromsaurav
Copy link
Contributor Author

Oh by the way...

We follow a linux kernel style of commit messages. With the context at the front followed by an action word and the rest. Would you mind changing the commit to something like this? It would be a good idea to squash the commit into one commit (but we can also do that at the end before we merge if you prefer).

frontend: app: i18n: Add Hindi language

oh sorry, my bad ! I'm fine with you squashing the commits during the merge process in the same linux kernel style. Thank you for the update!

@joaquimrocha joaquimrocha merged commit 61560f8 into kubernetes-sigs:main May 20, 2025
1 of 2 checks passed
@joaquimrocha
Copy link
Contributor

Thank you @fromsaurav !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

Development

Successfully merging this pull request may close these issues.

i18n: Add hindi language

4 participants