frontend: cluster: Add Overview stories#3412
Conversation
|
|
|
Welcome @1012Charan! |
0b42c67 to
752234f
Compare
skoeva
left a comment
There was a problem hiding this comment.
Looks solid, would be nice to have screenshots in the description for the new stories
Also good to rebase against main to pull the latest changes
|
Thanks for the suggestion @skoeva! I've updated this branch added the screenshots, but I noticed that all three states — Empty, Loading, and Error — look almost the same in Storybook. I’m not sure if that’s okay or if I might have missed something, so please let me know if any changes are needed! |
skoeva
left a comment
There was a problem hiding this comment.
The similar states should be fine, I would just squash the commits once you're done rebasing. Make sure to update the snapshots too: run make frontend-test locally and you can see which are failing
e16f1c7 to
9bf2886
Compare
|
@skoeva I've rebased the branch, squashed the commits, and updated the snapshots as requested. Since this was my first time working with things like squash and rebase, it was an exciting learning experience — so if I missed anything or made mistakes, please feel free to point them out. Also, while running the tests, I noticed a failure in the LoadingState due to it simulating an endless request. If you'd like, I can update it to use a timeout-based delay instead. |
b6143d3 to
25e32f4
Compare
|
sure, no need to mock an endless request. the frontend test still seems to be failing, are you seeing something different locally? |
|
@skoeva You're right — I rechecked and the LoadingState test is still failing on my side too. I think it's because the mocked API requests never resolve (to simulate loading), so the test waits indefinitely and throws a waiting error. Would it be okay to skip this story in the tests using: LoadingState.parameters = { Also, another issue was simple-eval causing the frontend tests to fail is now fixed — I had missed installing it initially, but after adding it, the other tests are passing fine. Let me know if this approach for the loading story makes sense or if you'd prefer a different fix! |
|
@skoeva Can you check this one? |
skoeva
left a comment
There was a problem hiding this comment.
I will test the frontend locally and I can try to help push up a fix for the CI
c80f58e to
b7078e6
Compare
|
@1012Charan Fixed the CI failures and removed the unnecessary changes, feel free to test locally and lmk if you notice anything |
|
Hi @skoeva , |
b7078e6 to
68cddcb
Compare
Co-authored-by: Evangelos Skopelitis <eskopelitis@microsoft.com> Co-authored-by: 1012Charan <charanvengala@gmail.com>
68cddcb to
bd534b2
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 1012Charan, illume The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adds 3 Storybook stories for the Overview component:
Screenshots for new stories :



EmptyState
LoadingState
ErrorState
Note: I noticed that the Empty, Loading, and Error states all look quite similar in Storybook — they seem to show the same fallback message or UI. I'm assuming this is expected because the Overview component handles these cases in a similar way with mock data, but please let me know if I might have missed something!