Skip to content

frontend: Ingress: Mark rules field as optional#3525

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
sniok:fix-ingress-rules-type
Jun 26, 2025
Merged

frontend: Ingress: Mark rules field as optional#3525
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
sniok:fix-ingress-rules-type

Conversation

@sniok
Copy link
Contributor

@sniok sniok commented Jun 26, 2025

This PR marks rules field in the Ingress object as optional, and updates usages accordingly

Related Issue

Fixes #3522

Steps to Test

  1. Create Ingress without rules
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: my-ingress
spec:
  defaultBackend:
    service:
      name: my-service
      port:
        number: 80
  1. Go to Map and make sure it doesn't crash

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 26, 2025
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 26, 2025
@sniok sniok requested review from skoeva and vyncent-t and removed request for illume and joaquimrocha June 26, 2025 13:54
@sniok sniok added frontend Issues related to the frontend kind/bug Categorizes issue or PR as related to a bug. labels Jun 26, 2025
Copy link
Contributor

@skoeva skoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this fix

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: skoeva, sniok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2a70a37 into kubernetes-sigs:main Jun 26, 2025
12 checks passed
@thomiceli thomiceli mentioned this pull request Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. frontend Issues related to the frontend kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Map throw an error

3 participants