Skip to content

Makefile: Update frontend-lint-fix command#3534

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
skoeva:lint-fix-commands
Jun 26, 2025
Merged

Makefile: Update frontend-lint-fix command#3534
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
skoeva:lint-fix-commands

Conversation

@skoeva
Copy link
Contributor

@skoeva skoeva commented Jun 26, 2025

This change updates the frontend lint fix make command from make frontend-fixlint to make frontend-lint-fix, in line with the backend lint commands.

Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
@skoeva skoeva self-assigned this Jun 26, 2025
@skoeva skoeva added the quality Related to improving the quality of the app label Jun 26, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 26, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 26, 2025
@skoeva skoeva linked an issue Jun 26, 2025 that may be closed by this pull request
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: skoeva, sniok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2025
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 Much better.

Should we leave the frontend-fixlint target as well, so we don't break anyone who is using it?

@sniok
Copy link
Contributor

sniok commented Jun 26, 2025

nice!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2025
@mboersma
Copy link
Contributor

Also, it would be nice to have a lint-fix target with backend-lint-fix and frontend-lint-fix as subtargets.

@skoeva
Copy link
Contributor Author

skoeva commented Jun 26, 2025

👍🏻 Much better.

Should we leave the frontend-fixlint target as well, so we don't break anyone who is using it?

@mboersma That probably isn't necessary, I think the other idea could be useful though

@k8s-ci-robot k8s-ci-robot merged commit 65353e3 into kubernetes-sigs:main Jun 26, 2025
13 checks passed
@skoeva skoeva deleted the lint-fix-commands branch June 26, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. quality Related to improving the quality of the app size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

frontend and backend lint fix commands are different

4 participants