frontend: AlertNotification: Update Storybook with new stories#3538
Merged
illume merged 1 commit intokubernetes-sigs:mainfrom Jul 2, 2025
Merged
frontend: AlertNotification: Update Storybook with new stories#3538illume merged 1 commit intokubernetes-sigs:mainfrom
illume merged 1 commit intokubernetes-sigs:mainfrom
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
Contributor
Author
|
Hey @skoeva i have made the changes here #3365 (review) |
skoeva
requested changes
Jun 27, 2025
Contributor
skoeva
left a comment
skoeva
left a comment
There was a problem hiding this comment.
Almost there, left a couple more final comments
ANIRUDH-SJ
force-pushed
the
feat/alert-notif-clean
branch
from
f02fc4f to
dd7f9e8
Compare
illume
approved these changes
Jul 2, 2025
Contributor
illume
left a comment
illume
left a comment
There was a problem hiding this comment.
LGTM, good work
I second that. Really nice work. Thanks a lot.
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ANIRUDH-SJ, illume, skoeva The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the Storybook for AlertNotification and created new stories.