Skip to content

frontend: CronJob: Spawn new job using cronjob's namespace#3543

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
skoeva:cronjob-ns
Jul 2, 2025
Merged

frontend: CronJob: Spawn new job using cronjob's namespace#3543
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
skoeva:cronjob-ns

Conversation

@skoeva
Copy link
Contributor

@skoeva skoeva commented Jun 30, 2025

This change sets a newly spawn job's namespace to the namespace of its cron job, rather than defaulting to the default namespace.

Testing

  • Open a cronjob in Headlamp
  • Spawn a new job and inspect the network requests
  • Ensure that the cronjob's namespace, rather than the default one, is displayed in the POST request headers

image

@skoeva skoeva self-assigned this Jun 30, 2025
@skoeva skoeva added the frontend Issues related to the frontend label Jun 30, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 30, 2025
@k8s-ci-robot k8s-ci-robot requested review from illume and sniok June 30, 2025 18:28
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 30, 2025
@skoeva skoeva linked an issue Jun 30, 2025 that may be closed by this pull request
Copy link
Contributor

@sniok sniok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 2, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: skoeva, sniok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2025
@k8s-ci-robot k8s-ci-robot merged commit 0bcc9ae into kubernetes-sigs:main Jul 2, 2025
12 checks passed
@skoeva skoeva deleted the cronjob-ns branch July 11, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. frontend Issues related to the frontend lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to spawn manual jobs from cronjobs

3 participants