Skip to content

resourceMap: Add loader for when it's lazy loading#3555

Draft
illume wants to merge 1 commit intomainfrom
resourceMapLoader
Draft

resourceMap: Add loader for when it's lazy loading#3555
illume wants to merge 1 commit intomainfrom
resourceMapLoader

Conversation

@illume
Copy link
Contributor

@illume illume commented Jul 3, 2025 •
edited
Loading

On a slower connection or system in dev mode it can take several seconds to download the code for the map.

Related Issue

Steps to Test

  1. Go to network tab of web browser developer tools and make it throttle at 4G speed
  2. Click on Map in headlamp
  3. Watch loader whilst map code is downloaded

@illume
resourceMap: Add loader for when it's lazy loading
0c0d651 
On a slower connection or system in dev mode it can take
several seconds to download the code for the map.
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: illume

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 3, 2025
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 3, 2025
@illume illume added kind/bug Categorizes issue or PR as related to a bug. resourceMap labels Jul 3, 2025
sniok
sniok requested changes Jul 3, 2025
View reviewed changes
Copy link
Contributor

@sniok sniok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change, I left a comment

frontend/src/lib/router.tsx
const { t } = useTranslation();

return (
<React.Suspense fallback={<Loader title={t('Loading')} />}>
Copy link
Contributor

@sniok sniok Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd put this into RouteSwitcher.tsx:56 so it would work for any other lazy loaded route as well

@joaquimrocha joaquimrocha removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 12, 2025

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 12, 2025
@illume illume marked this pull request as draft October 2, 2025 13:49
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 2, 2025
@k8s-triage-robot
Copy link

k8s-triage-robot commented Dec 31, 2025

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 31, 2025
@illume illume modified the milestones: v0.40.0, v0.39.0 Dec 31, 2025
@k8s-triage-robot
Copy link

k8s-triage-robot commented Jan 30, 2026

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 30, 2026
@illume illume modified the milestones: v0.40.0, 0.41.0 Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sniok sniok sniok requested changes

@joaquimrocha joaquimrocha Awaiting requested review from joaquimrocha

@vyncent-t vyncent-t Awaiting requested review from vyncent-t

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. resourceMap size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v0.41.0

Development

Successfully merging this pull request may close these issues.

5 participants

@illume @k8s-ci-robot @k8s-triage-robot @sniok @joaquimrocha