frontend: cleanup crds view#3561
Merged
illume merged 1 commit intokubernetes-sigs:mainfrom Jul 7, 2025
Merged
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XXL
Signed-off-by: farodin91 <github@jan-jansen.net>
farodin91
force-pushed
the
frontend--cleanup-crds-view
branch
from
c0c74d8 to
75cd17a
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the CRD views to align with other list views by unifying component imports, adjusting namespace filters, and introducing a backLink/subtitle pattern across resource lists.
- Unified imports and removed obsolete renderer components in CustomResourceList and CustomResourceDefinitionList.
- Added
backLinkandsubtitlesupport inResourceListViewandCustomResourceListTable. - Updated snapshots to match the cleaned-up grid and filter layouts.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/components/crd/snapshots/CustomResourceList.List.stories.storyshot | Cleaned up grid wrappers and added new filter widget in snapshots |
| frontend/src/components/crd/snapshots/CustomResourceDefinition.List.stories.storyshot | Removed duplicate filter section from snapshot |
| frontend/src/components/crd/snapshots/CustomResourceDefinition.Details.stories.storyshot | Added Back button, Create icon, and filter UI in details snapshot |
| frontend/src/components/crd/List.tsx | Disabled namespace filter on CRD list and consolidated imports |
| frontend/src/components/crd/CustomResourceList.tsx | Dropped legacy renderer, set default title, and grouped imports |
| frontend/src/components/crd/CustomResourceInstancesList.tsx | Grouped imports and removed SectionBox wrapper around instances view |
| frontend/src/components/common/Resource/ResourceListView.tsx | Introduced backLink prop and subtitle support in ResourceListView |
Comments suppressed due to low confidence (2)
frontend/src/components/common/Resource/ResourceListView.tsx:28
- The comment has a typo with an extra parenthesis and uses incorrect JSDoc syntax (
//**instead of/**); consider using a proper JSDoc block and correcting the typo to improve clarity.
//** The location to go back to. If provided as an empty string, the browser's history will be used. If not provided (default)), then no back button is used. */
frontend/src/components/crd/CustomResourceInstancesList.tsx:77
- [nitpick] The
SectionBoxwrapper withbackLinkwas removed, which may remove navigation controls and styling; consider reintroducing a wrapper or configuring abackLinkprop to preserve consistent layout and back navigation.
<>
Contributor
|
Removing the namespace filter from the CRD list is good, because that didn't make any sense. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: farodin91, illume The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds feature by make crds more consistent with other views.
Related Issue
Fixes #ISSUE_NUMBER
Changes
Steps to Test
Screenshots (if applicable)
Notes for the Reviewer