github: Add hl-ci- as a branch name prefix#3581
Merged
joaquimrocha merged 1 commit intokubernetes-sigs:mainfrom Jul 7, 2025
Merged
Conversation
So we do not get branch protection on these CI related branches. Signed-off-by: Joaquim Rocha <joaquim.rocha@microsoft.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR prefixes CI workflow branch names with hl-ci- to bypass Kubernetes branch protection and simplify cleanup.
- Updated branch creation, push, and PR commands to use
hl-ci-prefixes in multiple workflows - Introduced
BRANCH_NAMEvariables for consistency inminikubeandhomebrewscripts - Adjusted echo URLs to reference new branch names
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/pr-to-update-winget.yml | Prefixed branch names and PR URL with hl-ci- |
| .github/workflows/pr-to-update-minikube.yml | Added BRANCH_NAME var and updated all branch operations |
| .github/workflows/pr-to-update-homebrew.yml | Added BRANCH_NAME var and updated all branch operations |
| .github/workflows/pr-to-update-choco.yml | Prefixed branch names and PR URL with hl-ci- |
| .github/workflows/pr-to-update-chart.yml | Prefixed BRANCH assignment with hl-ci- |
Comments suppressed due to low confidence (3)
.github/workflows/pr-to-update-chart.yml:53
- Quote
$BRANCHin the grep command (grep -q "$BRANCH") to avoid potential word-splitting or unexpected pattern matching.
if git branch -l | grep -q $BRANCH; then
.github/workflows/pr-to-update-chart.yml:52
- To prevent push failures when a remote branch already exists, add logic to delete
origin/$BRANCH(e.g.,git push origin --delete "$BRANCH") before creating the new branch.
BRANCH=hl-ci-update_chart_headlamp_$LATEST_HEADLAMP_TAG
.github/workflows/pr-to-update-choco.yml:103
- The double
echocauses the literalecho "..."to be printed. Remove the extraechoso the URL is output directly (e.g.,echo "https://...").
echo echo "https://github.com/kubernetes-sigs/headlamp/pull/new/hl-ci-choco-update-$LATEST_HEADLAMP_TAG"
skoeva
approved these changes
Jul 7, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joaquimrocha, skoeva The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the branches used in CI workflows so they have the hl-ci- prefix, which doesn't get protected by the kubernetes branch policies, thus allowing us to delete/update them easily.
Notes for the Reviewer
No test needed since this will be related to the release. Just double check if the logic makes sense and there are no typos or things like that.