frontend: Implement new Activity feature for tabs and windows#3583
frontend: Implement new Activity feature for tabs and windows#3583k8s-ci-robot merged 26 commits intokubernetes-sigs:mainfrom
Conversation
40329e3 to
ea7c7cf
Compare
There was a problem hiding this comment.
Pull Request Overview
Introduces a generic Activity system for managing UI panels as tabs/windows and replaces the old detail-drawer mode throughout the frontend.
- Registers the new
activityReducerin the root Redux reducer and ports stream calls to include cluster context. - Adds
Activity.launch,Activity.update, andActivity.closecalls across components (pods, editors, logs, search links, etc.). - Updates i18n keys for new UI options (“Window”, “Full page”, “Overview”) and removes old “Overlay” drawer toggle.
Reviewed Changes
Copilot reviewed 59 out of 59 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| frontend/src/redux/reducers/reducers.tsx | Adds activity slice to combined reducers |
| frontend/src/components/common/Resource/CreateButton.tsx | Replaces dialog-state with Activity.launch for creation |
| frontend/src/i18n/locales/zh/translation.json (and other locales) | Adds keys for new Activity modes and removes “Overlay” |
Comments suppressed due to low confidence (1)
frontend/src/i18n/locales/zh/translation.json:12
- The translation value for "Window" is empty; please provide the proper Chinese translation to ensure localization completeness.
"Overview": "概览",
|
Oops, clicked submit too early. One sec. |
joaquimrocha
left a comment
There was a problem hiding this comment.
Great job @sniok ! It does bring Headlamp to another level of productivity.
Please do check my comments in some of the code.
Here are also some issues I found during testing:
- The Node Shell doesn't use the windowed rendering
- In the map view, the taskbar covers the map zoom lower side buttons
- I wonder how discoverable the snapping left/right is. Would it work if we added snap-left/snap-right/maximize buttons to the right of the drag-::: handle? Leaving only the minizime + close button to the right? (maybe it looks bad, just throwing out ideas)
|
Wow! Great findings @yolossn ! Thank you! |
…references and namespace
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joaquimrocha, sniok The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |


This PR adds new Activity concept, allowing users to manage terminals, logs, and tasks outside of a details view.
It's a generic system for opening new tabs/window, resizing them, minimizing.
This replaces drawer mode.
You create a new activity by calling
All activities are stored in the activitySlice redux store.
Settings were updated
Related Issue
Fixes #3486 #3419
Steps to Test
Testing done