Skip to content

fix: package pattern in helm chart release workflow#4215

Merged
illume merged 3 commits intokubernetes-sigs:mainfrom
onedr0p:patch-2
Feb 1, 2026
Merged

fix: package pattern in helm chart release workflow#4215
illume merged 3 commits intokubernetes-sigs:mainfrom
onedr0p:patch-2

Conversation

@onedr0p
Copy link
Contributor

@onedr0p onedr0p commented Nov 27, 2025

This was pointed out in https://github.com/kubernetes-sigs/headlamp/pull/3024/files#r2318193831

Summary

this fails because it tries to push provenance files

https://github.com/kubernetes-sigs/headlamp/actions/runs/17425865523/job/49472773512

Error: file '.cr-release-packages/headlamp-0.35.0.tgz.prov' does not appear to be a gzipped archive; got 'text/plain; charset=utf-8'

Related Issue

Fixes #2987

This was pointed out in https://github.com/kubernetes-sigs/headlamp/pull/3024/files#r2318193831

Signed-off-by: Devin Buhl <onedr0p@users.noreply.github.com>
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 27, 2025
@onedr0p
Copy link
Contributor Author

onedr0p commented Nov 27, 2025

We also need a maintainer to make this package public

ghcr.io/kubernetes-sigs/headlamp/charts/headlamp

@joaquimrocha
Copy link
Contributor

We also need a maintainer to make this package public

ghcr.io/kubernetes-sigs/headlamp/charts/headlamp

AFAIU, we are not supposed to use ghcr.io but the official Kubernetes registry for that. I need some time to go over that and understand exactly how to publish it.

@onedr0p
Copy link
Contributor Author

onedr0p commented Nov 27, 2025

Ugh, yeah that makes sense. I honestly forgot headlamp needed to follow kubernetes-sigs guidelines now that it's part of the org. There's a lot of effort in even getting older apps charts to publish to OCI...

Although some had success...

Good luck on figuring it out because it seems like there is no clear indication of how to proceed.

@illume
Copy link
Contributor

illume commented Feb 1, 2026

I wonder what needs to be done on this PR?

@onedr0p Do you still want this merged in? It's not clear to me.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the package pattern in the Helm chart release workflow to specifically match .tgz files instead of all files in the .cr-release-packages/ directory. This change was identified as needed during review of PR #3024, which introduced the functionality to push Helm charts to GitHub Container Registry (GHCR) as OCI artifacts.

Changes:

  • Updated glob pattern from .cr-release-packages/* to .cr-release-packages/*.tgz to specifically target packaged Helm chart files
  • Removed an extraneous blank line for cleaner formatting

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@onedr0p
Copy link
Contributor Author

onedr0p commented Feb 1, 2026

@illume yes, this would be nice to have merged.

Copy link
Contributor

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: illume, onedr0p

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2026
@illume illume merged commit 283fbdc into kubernetes-sigs:main Feb 1, 2026
11 of 12 checks passed
@illume illume added CI Issue related to CI kind/bug Categorizes issue or PR as related to a bug. labels Feb 1, 2026
@illume illume added this to the v0.40.0 milestone Feb 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. CI Issue related to CI cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request: Upload Helm chart to OCI registry

4 participants