fix: package pattern in helm chart release workflow#4215
fix: package pattern in helm chart release workflow#4215illume merged 3 commits intokubernetes-sigs:mainfrom
Conversation
This was pointed out in https://github.com/kubernetes-sigs/headlamp/pull/3024/files#r2318193831 Signed-off-by: Devin Buhl <onedr0p@users.noreply.github.com>
|
We also need a maintainer to make this package public |
AFAIU, we are not supposed to use ghcr.io but the official Kubernetes registry for that. I need some time to go over that and understand exactly how to publish it. |
|
Ugh, yeah that makes sense. I honestly forgot headlamp needed to follow kubernetes-sigs guidelines now that it's part of the org. There's a lot of effort in even getting older apps charts to publish to OCI...
Although some had success...
Good luck on figuring it out because it seems like there is no clear indication of how to proceed. |
|
I wonder what needs to be done on this PR? @onedr0p Do you still want this merged in? It's not clear to me. |
There was a problem hiding this comment.
Pull request overview
This PR fixes the package pattern in the Helm chart release workflow to specifically match .tgz files instead of all files in the .cr-release-packages/ directory. This change was identified as needed during review of PR #3024, which introduced the functionality to push Helm charts to GitHub Container Registry (GHCR) as OCI artifacts.
Changes:
- Updated glob pattern from
.cr-release-packages/*to.cr-release-packages/*.tgzto specifically target packaged Helm chart files - Removed an extraneous blank line for cleaner formatting
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@illume yes, this would be nice to have merged. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: illume, onedr0p The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was pointed out in https://github.com/kubernetes-sigs/headlamp/pull/3024/files#r2318193831
Summary
Related Issue
Fixes #2987