frontend: Label: Fix warning label color contrast#4284
Merged
illume merged 1 commit intokubernetes-sigs:mainfrom Jan 6, 2026
Merged
frontend: Label: Fix warning label color contrast#4284illume merged 1 commit intokubernetes-sigs:mainfrom
illume merged 1 commit intokubernetes-sigs:mainfrom
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
vyncent-t
added
frontend
k8s-ci-robot
added
the
size/S
|
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-contributor-experience at kubernetes/community. /check-cla |
k8s-ci-robot
added
the
cncf-cla: yes
skoeva
reviewed
Dec 29, 2025
Contributor
skoeva
left a comment
skoeva
left a comment
There was a problem hiding this comment.
CI failure should also go away with a rebase
vyncent-t
force-pushed
the
fix-contrast-cluster-labels
branch
from
56fc4e4 to
456aa2d
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: illume, vyncent-t The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
17 tasks
illume
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ran FastPass and it seems there is an issue when using white text and orange background. I have tried adjusting the background color to be darker to match allowed contrast, but this results in the "allowed" orange basically being just red. (Please refer to the image above for details)
This clashes with the red color used for failures so I am opting for a use of black text when displaying orange labels in light mode.
Changes
Steps to Test
Screenshots
Before
After