Skip to content

docs: Fix Dex OIDC block indentation in values.yaml snippet#4339

Merged
illume merged 1 commit intokubernetes-sigs:mainfrom
archups:fix/dex-oidc-indentation
Feb 1, 2026
Merged

docs: Fix Dex OIDC block indentation in values.yaml snippet#4339
illume merged 1 commit intokubernetes-sigs:mainfrom
archups:fix/dex-oidc-indentation

Conversation

@archups
Copy link
Contributor

@archups archups commented Jan 8, 2026

Summary

This PR fixes oidc block indentation in values.yaml snippet in docs/installation/in-cluster/dex.

Related Issue

Changes

  • Fixed [indentation]

Steps to Test

Screenshots (if applicable)

Notes for the Reviewer

@k8s-ci-robot k8s-ci-robot requested a review from illume January 8, 2026 07:11
@k8s-ci-robot
Copy link
Contributor

Welcome @archups!

It looks like this is your first PR to kubernetes-sigs/headlamp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/headlamp has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot requested a review from vyncent-t January 8, 2026 07:11
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 8, 2026
Copy link
Contributor

@skoeva skoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching this, just a nit: would you mind shortening the PR/commit title? I can see it goes into the commit message

Signed-off-by: Archana Sawant <archupsawant@gmail.com>
@archups archups force-pushed the fix/dex-oidc-indentation branch from 4eedbf6 to fc45201 Compare January 9, 2026 13:52
@archups archups changed the title docs: installation/in-cluster/dex fix oidc block indentation in values.yaml snippet docs: Fix Dex OIDC block indentation in values.yaml snippet Jan 9, 2026
@archups
Copy link
Contributor Author

archups commented Jan 9, 2026

thanks for catching this, just a nit: would you mind shortening the PR/commit title? I can see it goes into the commit message

Thank you @skoeva for reviewing it and providing feedback. I have shortened PR/commit title. Hope this looks fine.

@archups archups requested a review from skoeva January 9, 2026 13:55
@illume illume added the documentation Improvements or additions to documentation label Feb 1, 2026
Copy link
Contributor

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: archups, illume

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2026
@illume illume added this to the v0.40.0 milestone Feb 1, 2026
@illume illume added the kind/bug Categorizes issue or PR as related to a bug. label Feb 1, 2026
@illume illume merged commit 418f13b into kubernetes-sigs:main Feb 1, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. documentation Improvements or additions to documentation kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants