frontend: Fix ARIA labels for input fields#4345
Merged
illume merged 1 commit intokubernetes-sigs:mainfrom Jan 16, 2026
Merged
Conversation
k8s-ci-robot
added
size/S
joaquimrocha
previously requested changes
Jan 9, 2026
frontend/src/components/secret/__snapshots__/Details.WithBase.stories.storyshot
Outdated
Show resolved
Hide resolved
k8s-ci-robot
added
the
do-not-merge/work-in-progress
vyncent-t
force-pushed
the
fix-aria-labels-secrets-page
branch
4 times, most recently
from
03eba6e to
f177d51
Compare
vyncent-t
force-pushed
the
fix-aria-labels-secrets-page
branch
from
f177d51 to
6717879
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
vyncent-t
requested review from
illume
and removed request for
ashu8912 and
yolossn
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves accessibility for secret field inputs by adding proper ARIA labels to associate input fields with their corresponding labels, addressing FastPass accessibility violations.
Changes:
- Added
nameIDprop toSecretFieldcomponent andNameValueTableRowinterface - Implemented
aria-labelledbyattribute on input elements to reference label IDs - Refactored Details.tsx to use destructuring for cleaner code and proper type casting
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| frontend/src/components/common/Resource/Resource.tsx | Added SecretFieldProps interface with nameID prop and applied aria-labelledby to Input component |
| frontend/src/components/secret/Details.tsx | Refactored data mapping to use destructuring and pass nameID to SecretField |
| frontend/src/components/secret/snapshots/Details.WithBase.stories.storyshot | Updated snapshot to reflect new ID and aria-labelledby attributes in rendered output |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: illume, vyncent-t The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes some a11y issues around missing labels for inputs in our custom component for secrets data fields.
FastPass scan
Inputs that need fixes
Related Issue
Fixes #4344
Changes
Steps to Test