Skip to content

fix(a11y)-4: add accessible name to VersionDialog using aria-label #4389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Sagar-6203620715 wants to merge 1 commit into
base: main
Choose a base branch
from
+691 −660
Draft

fix(a11y)-4: add accessible name to VersionDialog using aria-label #4389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions frontend/src/components/App/Home/__snapshots__/index.Base.stories.storyshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,12 +241,12 @@
>
<span
aria-label="Toggle select all"
class="MuiButtonBase-root MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeSmall PrivateSwitchBase-root MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeSmall MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeSmall css-1li6ni2-MuiButtonBase-root-MuiCheckbox-root"
class="MuiButtonBase-root MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeSmall PrivateSwitchBase-root MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeSmall MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeSmall css-3nlepf-MuiButtonBase-root-MuiSwitchBase-root-MuiCheckbox-root"
data-mui-internal-clone-element="true"
>
<input
aria-label="Toggle select all"
class="PrivateSwitchBase-input css-1m9pwf3"
class="PrivateSwitchBase-input css-1p3z7et-MuiSwitchBase-root"
data-indeterminate="false"
type="checkbox"
/>
Expand Down Expand Up @@ -585,12 +585,12 @@
>
<span
aria-label="Toggle select row"
class="MuiButtonBase-root MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeSmall PrivateSwitchBase-root MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeSmall MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeSmall css-1li6ni2-MuiButtonBase-root-MuiCheckbox-root"
class="MuiButtonBase-root MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeSmall PrivateSwitchBase-root MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeSmall MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeSmall css-3nlepf-MuiButtonBase-root-MuiSwitchBase-root-MuiCheckbox-root"
data-mui-internal-clone-element="true"
>
<input
aria-label="Toggle select row"
class="PrivateSwitchBase-input css-1m9pwf3"
class="PrivateSwitchBase-input css-1p3z7et-MuiSwitchBase-root"
data-indeterminate="false"
type="checkbox"
/>
Expand Down Expand Up @@ -685,12 +685,12 @@
>
<span
aria-label="Toggle select row"
class="MuiButtonBase-root MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeSmall PrivateSwitchBase-root MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeSmall MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeSmall css-1li6ni2-MuiButtonBase-root-MuiCheckbox-root"
class="MuiButtonBase-root MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeSmall PrivateSwitchBase-root MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeSmall MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeSmall css-3nlepf-MuiButtonBase-root-MuiSwitchBase-root-MuiCheckbox-root"
data-mui-internal-clone-element="true"
>
<input
aria-label="Toggle select row"
class="PrivateSwitchBase-input css-1m9pwf3"
class="PrivateSwitchBase-input css-1p3z7et-MuiSwitchBase-root"
data-indeterminate="false"
type="checkbox"
/>
Expand Down Expand Up @@ -785,12 +785,12 @@
>
<span
aria-label="Toggle select row"
class="MuiButtonBase-root MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeSmall PrivateSwitchBase-root MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeSmall MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeSmall css-1li6ni2-MuiButtonBase-root-MuiCheckbox-root"
class="MuiButtonBase-root MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeSmall PrivateSwitchBase-root MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeSmall MuiCheckbox-root MuiCheckbox-colorPrimary MuiCheckbox-sizeSmall css-3nlepf-MuiButtonBase-root-MuiSwitchBase-root-MuiCheckbox-root"
data-mui-internal-clone-element="true"
>
<input
aria-label="Toggle select row"
class="PrivateSwitchBase-input css-1m9pwf3"
class="PrivateSwitchBase-input css-1p3z7et-MuiSwitchBase-root"
data-indeterminate="false"
type="checkbox"
/>
Expand Down
2 changes: 1 addition & 1 deletion ...rc/components/App/PluginSettings/__snapshots__/PluginSettings.MoreItems.stories.storyshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1361,7 +1361,7 @@
Rows per page
</label>
<div
class="MuiInputBase-root MuiInput-root MuiInputBase-colorPrimary css-dnm9fb-MuiInputBase-root-MuiInput-root-MuiSelect-root"
class="MuiInputBase-root MuiInput-root MuiInputBase-colorPrimary css-dnm9fb-MuiInputBase-root-MuiInput-root-MuiSelect-root"
>
<div
aria-controls="test-id"
Expand Down
4 changes: 2 additions & 2 deletions ...nts/App/PluginSettings/__snapshots__/PluginSettingsDetails.WithAutoSave.stories.storyshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,10 @@
/>
<fieldset
aria-hidden="true"
class="MuiOutlinedInput-notchedOutline css-1d3z3hw-MuiOutlinedInput-notchedOutline"
class="MuiOutlinedInput-notchedOutline css-r01yff-MuiNotchedOutlined-root-MuiOutlinedInput-notchedOutline"
>
<legend
class="css-yjsfm1"
class="css-njhac4-MuiNotchedOutlined-root"
>
<span>
Normal Input
Expand Down
4 changes: 2 additions & 2 deletions .../App/PluginSettings/__snapshots__/PluginSettingsDetails.WithoutAutoSave.stories.storyshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,10 @@
/>
<fieldset
aria-hidden="true"
class="MuiOutlinedInput-notchedOutline css-1d3z3hw-MuiOutlinedInput-notchedOutline"
class="MuiOutlinedInput-notchedOutline css-r01yff-MuiNotchedOutlined-root-MuiOutlinedInput-notchedOutline"
>
<legend
class="css-yjsfm1"
class="css-njhac4-MuiNotchedOutlined-root"
>
<span>
Normal Input
Expand Down
6 changes: 3 additions & 3 deletions frontend/src/components/App/Settings/__snapshots__/ClusterSelector.Default.stories.storyshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
</label>
<div
aria-label="Cluster selector"
class="MuiInputBase-root MuiOutlinedInput-root MuiInputBase-colorPrimary MuiInputBase-formControl MuiInputBase-sizeSmall css-1yk1gt9-MuiInputBase-root-MuiOutlinedInput-root-MuiSelect-root"
class="MuiInputBase-root MuiOutlinedInput-root MuiInputBase-colorPrimary MuiInputBase-formControl MuiInputBase-sizeSmall css-1yk1gt9-MuiInputBase-root-MuiOutlinedInput-root-MuiSelect-root"
>
<div
aria-controls=":mock-test-id:"
Expand Down Expand Up @@ -45,10 +45,10 @@
</svg>
<fieldset
aria-hidden="true"
class="MuiOutlinedInput-notchedOutline css-1d3z3hw-MuiOutlinedInput-notchedOutline"
class="MuiOutlinedInput-notchedOutline css-r01yff-MuiNotchedOutlined-root-MuiOutlinedInput-notchedOutline"
>
<legend
class="css-14lo706"
class="css-sl37lx-MuiNotchedOutlined-root"
>
<span>
Cluster
Expand Down
12 changes: 6 additions & 6 deletions ...end/src/components/App/Settings/__snapshots__/NodeShellSettings.Default.stories.storyshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,12 @@
class="MuiSwitch-root MuiSwitch-sizeMedium css-julti5-MuiSwitch-root"
>
<span
class="MuiButtonBase-root MuiSwitch-switchBase MuiSwitch-colorPrimary Mui-checked PrivateSwitchBase-root MuiSwitch-switchBase MuiSwitch-colorPrimary Mui-checked Mui-checked css-1emuodk-MuiButtonBase-root-MuiSwitch-switchBase"
class="MuiButtonBase-root MuiSwitch-switchBase MuiSwitch-colorPrimary Mui-checked PrivateSwitchBase-root MuiSwitch-switchBase MuiSwitch-colorPrimary Mui-checked Mui-checked css-po6g13-MuiButtonBase-root-MuiSwitchBase-root-MuiSwitch-switchBase"
>
<input
aria-labelledby="node-shell-enabled-label"
checked=""
class="PrivateSwitchBase-input MuiSwitch-input css-1m9pwf3"
class="PrivateSwitchBase-input MuiSwitch-input css-1p3z7et-MuiSwitchBase-root"
type="checkbox"
/>
<span
Expand Down Expand Up @@ -91,10 +91,10 @@
/>
<fieldset
aria-hidden="true"
class="MuiOutlinedInput-notchedOutline css-1d3z3hw-MuiOutlinedInput-notchedOutline"
class="MuiOutlinedInput-notchedOutline css-r01yff-MuiNotchedOutlined-root-MuiOutlinedInput-notchedOutline"
>
<legend
class="css-ihdtdm"
class="css-1whs34k-MuiNotchedOutlined-root"
>
<span
class="notranslate"
Expand Down Expand Up @@ -137,10 +137,10 @@
/>
<fieldset
aria-hidden="true"
class="MuiOutlinedInput-notchedOutline css-1d3z3hw-MuiOutlinedInput-notchedOutline"
class="MuiOutlinedInput-notchedOutline css-r01yff-MuiNotchedOutlined-root-MuiOutlinedInput-notchedOutline"
>
<legend
class="css-ihdtdm"
class="css-1whs34k-MuiNotchedOutlined-root"
>
<span
class="notranslate"
Expand Down
28 changes: 14 additions & 14 deletions frontend/src/components/App/Settings/__snapshots__/Settings.General.stories.storyshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
class="MuiFormControl-root css-1nrlq1o-MuiFormControl-root"
>
<div
class="MuiInputBase-root MuiOutlinedInput-root MuiInputBase-colorPrimary MuiInputBase-formControl MuiInputBase-sizeSmall css-uwmwwo-MuiInputBase-root-MuiOutlinedInput-root-MuiSelect-root"
class="MuiInputBase-root MuiOutlinedInput-root MuiInputBase-colorPrimary MuiInputBase-formControl MuiInputBase-sizeSmall css-uwmwwo-MuiInputBase-root-MuiOutlinedInput-root-MuiSelect-root"
>
<div
aria-controls="under-test"
Expand Down Expand Up @@ -116,10 +116,10 @@
</svg>
<fieldset
aria-hidden="true"
class="MuiOutlinedInput-notchedOutline css-1d3z3hw-MuiOutlinedInput-notchedOutline"
class="MuiOutlinedInput-notchedOutline css-r01yff-MuiNotchedOutlined-root-MuiOutlinedInput-notchedOutline"
>
<legend
class="css-ihdtdm"
class="css-1whs34k-MuiNotchedOutlined-root"
>
<span
class="notranslate"
Expand Down Expand Up @@ -213,7 +213,7 @@
class="MuiFormControl-root css-1nrlq1o-MuiFormControl-root"
>
<div
class="MuiInputBase-root MuiOutlinedInput-root MuiInputBase-colorPrimary MuiInputBase-formControl MuiInputBase-sizeSmall css-uwmwwo-MuiInputBase-root-MuiOutlinedInput-root-MuiSelect-root"
class="MuiInputBase-root MuiOutlinedInput-root MuiInputBase-colorPrimary MuiInputBase-formControl MuiInputBase-sizeSmall css-uwmwwo-MuiInputBase-root-MuiOutlinedInput-root-MuiSelect-root"
style="width: 100px;"
>
<div
Expand Down Expand Up @@ -247,10 +247,10 @@
</svg>
<fieldset
aria-hidden="true"
class="MuiOutlinedInput-notchedOutline css-1d3z3hw-MuiOutlinedInput-notchedOutline"
class="MuiOutlinedInput-notchedOutline css-r01yff-MuiNotchedOutlined-root-MuiOutlinedInput-notchedOutline"
>
<legend
class="css-ihdtdm"
class="css-1whs34k-MuiNotchedOutlined-root"
>
<span
class="notranslate"
Expand Down Expand Up @@ -296,7 +296,7 @@
role="combobox"
spellcheck="false"
type="text"
value=""
value="(UTC+0) UTC"
/>
<div
class="MuiAutocomplete-endAdornment css-p1olib-MuiAutocomplete-endAdornment"
Expand Down Expand Up @@ -326,10 +326,10 @@
</div>
<fieldset
aria-hidden="true"
class="MuiOutlinedInput-notchedOutline css-1d3z3hw-MuiOutlinedInput-notchedOutline"
class="MuiOutlinedInput-notchedOutline css-r01yff-MuiNotchedOutlined-root-MuiOutlinedInput-notchedOutline"
>
<legend
class="css-ihdtdm"
class="css-1whs34k-MuiNotchedOutlined-root"
>
<span
class="notranslate"
Expand All @@ -340,7 +340,7 @@
</fieldset>
</div>
<p
class="MuiFormHelperText-root MuiFormHelperText-sizeSmall MuiFormHelperText-contained css-153yz37-MuiFormHelperText-root"
class="MuiFormHelperText-root MuiFormHelperText-sizeSmall MuiFormHelperText-contained MuiFormHelperText-filled css-153yz37-MuiFormHelperText-root"
id="cluster-selector-autocomplete-helper-text"
>
Timezone
Expand All @@ -362,11 +362,11 @@
class="MuiSwitch-root MuiSwitch-sizeMedium css-julti5-MuiSwitch-root"
>
<span
class="MuiButtonBase-root MuiSwitch-switchBase MuiSwitch-colorPrimary PrivateSwitchBase-root MuiSwitch-switchBase MuiSwitch-colorPrimary css-1emuodk-MuiButtonBase-root-MuiSwitch-switchBase"
class="MuiButtonBase-root MuiSwitch-switchBase MuiSwitch-colorPrimary PrivateSwitchBase-root MuiSwitch-switchBase MuiSwitch-colorPrimary css-po6g13-MuiButtonBase-root-MuiSwitchBase-root-MuiSwitch-switchBase"
>
<input
aria-labelledby="sort-sidebar-label"
class="PrivateSwitchBase-input MuiSwitch-input css-1m9pwf3"
class="PrivateSwitchBase-input MuiSwitch-input css-1p3z7et-MuiSwitchBase-root"
type="checkbox"
/>
<span
Expand Down Expand Up @@ -394,12 +394,12 @@
class="MuiSwitch-root MuiSwitch-sizeMedium css-julti5-MuiSwitch-root"
>
<span
class="MuiButtonBase-root MuiSwitch-switchBase MuiSwitch-colorPrimary Mui-checked PrivateSwitchBase-root MuiSwitch-switchBase MuiSwitch-colorPrimary Mui-checked Mui-checked css-1emuodk-MuiButtonBase-root-MuiSwitch-switchBase"
class="MuiButtonBase-root MuiSwitch-switchBase MuiSwitch-colorPrimary Mui-checked PrivateSwitchBase-root MuiSwitch-switchBase MuiSwitch-colorPrimary Mui-checked Mui-checked css-po6g13-MuiButtonBase-root-MuiSwitchBase-root-MuiSwitch-switchBase"
>
<input
aria-labelledby="use-evict-label"
checked=""
class="PrivateSwitchBase-input MuiSwitch-input css-1m9pwf3"
class="PrivateSwitchBase-input MuiSwitch-input css-1p3z7et-MuiSwitchBase-root"
type="checkbox"
/>
<span
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/components/App/__snapshots__/Layout.Default.stories.storyshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,10 @@
</div>
<fieldset
aria-hidden="true"
class="MuiOutlinedInput-notchedOutline css-1d3z3hw-MuiOutlinedInput-notchedOutline"
class="MuiOutlinedInput-notchedOutline css-r01yff-MuiNotchedOutlined-root-MuiOutlinedInput-notchedOutline"
>
<legend
class="css-ihdtdm"
class="css-1whs34k-MuiNotchedOutlined-root"
>
<span
class="notranslate"
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/components/App/__snapshots__/Layout.ErrorState.stories.storyshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,10 @@
</div>
<fieldset
aria-hidden="true"
class="MuiOutlinedInput-notchedOutline css-1d3z3hw-MuiOutlinedInput-notchedOutline"
class="MuiOutlinedInput-notchedOutline css-r01yff-MuiNotchedOutlined-root-MuiOutlinedInput-notchedOutline"
>
<legend
class="css-ihdtdm"
class="css-1whs34k-MuiNotchedOutlined-root"
>
<span
class="notranslate"
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/components/App/__snapshots__/Layout.MultiCluster.stories.storyshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,10 @@
</div>
<fieldset
aria-hidden="true"
class="MuiOutlinedInput-notchedOutline css-1d3z3hw-MuiOutlinedInput-notchedOutline"
class="MuiOutlinedInput-notchedOutline css-r01yff-MuiNotchedOutlined-root-MuiOutlinedInput-notchedOutline"
>
<legend
class="css-ihdtdm"
class="css-1whs34k-MuiNotchedOutlined-root"
>
<span
class="notranslate"
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/components/App/__snapshots__/Layout.WithClusterRoute.stories.storyshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,10 @@
</div>
<fieldset
aria-hidden="true"
class="MuiOutlinedInput-notchedOutline css-1d3z3hw-MuiOutlinedInput-notchedOutline"
class="MuiOutlinedInput-notchedOutline css-r01yff-MuiNotchedOutlined-root-MuiOutlinedInput-notchedOutline"
>
<legend
class="css-ihdtdm"
class="css-1whs34k-MuiNotchedOutlined-root"
>
<span
class="notranslate"
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/components/App/__snapshots__/TopBar.EmptyUserInfo.stories.storyshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,10 +100,10 @@
</div>
<fieldset
aria-hidden="true"
class="MuiOutlinedInput-notchedOutline css-1d3z3hw-MuiOutlinedInput-notchedOutline"
class="MuiOutlinedInput-notchedOutline css-r01yff-MuiNotchedOutlined-root-MuiOutlinedInput-notchedOutline"
>
<legend
class="css-ihdtdm"
class="css-1whs34k-MuiNotchedOutlined-root"
>
<span
class="notranslate"
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/components/App/__snapshots__/TopBar.NoToken.stories.storyshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,10 +100,10 @@
</div>
<fieldset
aria-hidden="true"
class="MuiOutlinedInput-notchedOutline css-1d3z3hw-MuiOutlinedInput-notchedOutline"
class="MuiOutlinedInput-notchedOutline css-r01yff-MuiNotchedOutlined-root-MuiOutlinedInput-notchedOutline"
>
<legend
class="css-ihdtdm"
class="css-1whs34k-MuiNotchedOutlined-root"
>
<span
class="notranslate"
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/components/App/__snapshots__/TopBar.OneCluster.stories.storyshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,10 +100,10 @@
</div>
<fieldset
aria-hidden="true"
class="MuiOutlinedInput-notchedOutline css-1d3z3hw-MuiOutlinedInput-notchedOutline"
class="MuiOutlinedInput-notchedOutline css-r01yff-MuiNotchedOutlined-root-MuiOutlinedInput-notchedOutline"
>
<legend
class="css-ihdtdm"
class="css-1whs34k-MuiNotchedOutlined-root"
>
<span
class="notranslate"
Expand Down
Loading
Loading