fix(a11y)-11: wrap RestartMultipleButton in MenuList to satisfy ARIA …#4393
fix(a11y)-11: wrap RestartMultipleButton in MenuList to satisfy ARIA …#4393Sagar-6203620715 wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Sagar-6203620715 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: Sagar Choudhary <sagar6203620715@gmail.com>
d53b794 to
d90b37b
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the RestartMultipleButton Storybook story to render the menu-style variant within an appropriate ARIA menu container, resolving the "ARIA required parent" violation for MenuItem.
Changes:
- Added MUI
MenuListandPaperimports to theRestartMultipleButtonstories file. - Introduced a
MenuTemplatestory that wrapsRestartMultipleButtonin<Paper><MenuList>...</MenuList></Paper>. - Updated the
MenuButtonStylestory to useMenuTemplate, ensuring thebuttonStyle="menu"variant is rendered under a proper ARIA parent.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
illume
left a comment
There was a problem hiding this comment.
Thanks for this!
To update the snapshots you can run this.
npm run test -- -u
You can check things locally with these commands.
npm run tsc
npm run lint
npm run test
npm run format
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
hey hey. I'll mark this as draft for now to make it easier on reviewers. If you want to continue it, please mark it as ready to review when you've pushed changes. |
Summary
This PR fixes an accessibility issue by ensuring menu items are rendered within a proper ARIA parent.
Related Issue
Partially fixes #4385
Addresses point 11 (ARIA required parent)
Changes
RestartMultipleButton.stories.tsxto wrap the component inMenuListPaperwrapper to provide a valid menu container in StorybookMenuItemSteps to Test
npm run frontend:test:a11yScreenshots (if applicable)
N/A
Notes for the Reviewer