Skip to content

fix(a11y)-11: wrap RestartMultipleButton in MenuList to satisfy ARIA …#4393

Draft
Sagar-6203620715 wants to merge 1 commit intokubernetes-sigs:mainfrom
Sagar-6203620715:fix-access-11
Draft

fix(a11y)-11: wrap RestartMultipleButton in MenuList to satisfy ARIA …#4393
Sagar-6203620715 wants to merge 1 commit intokubernetes-sigs:mainfrom
Sagar-6203620715:fix-access-11

Conversation

@Sagar-6203620715
Copy link
Contributor

Summary

This PR fixes an accessibility issue by ensuring menu items are rendered within a proper ARIA parent.

Related Issue

Partially fixes #4385
Addresses point 11 (ARIA required parent)

Changes

  • Updated RestartMultipleButton.stories.tsx to wrap the component in MenuList
  • Added Paper wrapper to provide a valid menu container in Storybook
  • Fixed ARIA required-parent violation for MenuItem

Steps to Test

  1. Run npm run frontend:test:a11y
  2. Open Storybook and navigate to the RestartMultipleButton → MenuButtonStyle story
  3. Verify no ARIA required-parent violations are reported

Screenshots (if applicable)

N/A

Notes for the Reviewer

  • Aligns with MUI and ARIA best practices

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Sagar-6203620715
Once this PR has been reviewed and has the lgtm label, please assign sniok for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 20, 2026
Signed-off-by: Sagar Choudhary <sagar6203620715@gmail.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the RestartMultipleButton Storybook story to render the menu-style variant within an appropriate ARIA menu container, resolving the "ARIA required parent" violation for MenuItem.

Changes:

  • Added MUI MenuList and Paper imports to the RestartMultipleButton stories file.
  • Introduced a MenuTemplate story that wraps RestartMultipleButton in <Paper><MenuList>...</MenuList></Paper>.
  • Updated the MenuButtonStyle story to use MenuTemplate, ensuring the buttonStyle="menu" variant is rendered under a proper ARIA parent.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

To update the snapshots you can run this.

npm run test -- -u

You can check things locally with these commands.

npm run tsc
npm run lint
npm run test
npm run format

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 12, 2026
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@illume
Copy link
Contributor

illume commented Feb 14, 2026

hey hey.

I'll mark this as draft for now to make it easier on reviewers. If you want to continue it, please mark it as ready to review when you've pushed changes.

@illume illume marked this pull request as draft February 14, 2026 13:00
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WIP: Accessibility Issues Tracking

3 participants