Skip to content

fix(a11y)-1: simplify Storybook headings to avoid over-nesting while …#4395

Draft
Sagar-6203620715 wants to merge 1 commit intokubernetes-sigs:mainfrom
Sagar-6203620715:fix-access-1
Draft

fix(a11y)-1: simplify Storybook headings to avoid over-nesting while …#4395
Sagar-6203620715 wants to merge 1 commit intokubernetes-sigs:mainfrom
Sagar-6203620715:fix-access-1

Conversation

@Sagar-6203620715
Copy link
Contributor

Summary

This PR fixes an accessibility issue in Storybook by simplifying the heading structure while maintaining a valid, non-skipped heading hierarchy required by axe.

Related Issue

Partially fixes #4385
Addresses point 1 from issue #4385

Changes

  • Reduced excessive heading levels in PluginSettings.stories.tsx
  • Preserved correct heading order to satisfy accessibility checks
  • Limited changes to Storybook-only content to avoid impacting production UI

Steps to Test

  1. Run Storybook locally.
  2. Open Settings → PluginSettings story.
  3. Run axe accessibility checks.
  4. Confirm no “skipped heading level” warnings are reported.

Screenshots (if applicable)

N/A

Notes for the Reviewer

  • Headings are intentionally minimal to avoid semantic over-engineering.
  • This change affects only Storybook and does not impact runtime UI behavior.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 20, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Sagar-6203620715
Once this PR has been reviewed and has the lgtm label, please assign joaquimrocha for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 20, 2026
@illume illume requested a review from Copilot January 31, 2026 15:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR attempts to fix accessibility heading hierarchy issues in Storybook stories by adding wrapper headings (h1 and h2) around component renders. The goal is to address axe accessibility violations related to skipped heading levels.

Changes:

  • Added h1 and h2 wrapper headings in three Storybook story files
  • Modified Template functions to wrap components in Box with heading elements
  • Imported Box component from @mui/material in all three files

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
frontend/src/components/common/ReleaseNotes/ReleaseNotesModal.stories.tsx Wraps ReleaseNotesModal in Box with h1 "Application" and h2 "Updates" headings
frontend/src/components/common/ReleaseNotes/ReleaseNotes.stories.tsx Wraps ReleaseNotes in Box with h1 "Application" and h2 "Release Information" headings
frontend/src/components/App/PluginSettings/PluginSettings.stories.tsx Wraps PluginSettingsPure in Box with h1 "Settings" and h2 "Plugins" headings

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

To update the snapshots you can run this.

npm run test -- -u

You can check things locally with these commands.

npm run tsc
npm run lint
npm run test
npm run format

Please check the open comments?

Signed-off-by: Sagar Choudhary <sagar6203620715@gmail.com>
@illume
Copy link
Contributor

illume commented Feb 14, 2026

hey hey.

It looks like a GitHub check is failing still.

I'll mark this as draft for now to make it easier on reviewers. If you want to continue it, please mark it as ready to review when you've pushed changes.

@illume illume marked this pull request as draft February 14, 2026 13:00
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WIP: Accessibility Issues Tracking

3 participants