fix: prevent crash when cluster name is undefined in getDetailsLink

[Sagar-6203620715]

Summary

This PR fixes a crash that occurs when accessing the Clusters page for clusters with undefined metadata.name (e.g., AWS EKS clusters with ARN-style names containing special characters like arn:aws:eks:eu-west-1:XXXXXXXXXXXX:cluster--xxx-xxxxxx-xxxx).

Related Issue

Fixes #4304

Changes

• Added null check in KubeObject.getDetailsLink() before generating route URLs
• Returns empty string with console warning when object name is undefined
• Prevents TypeError: Expected "name" to be defined from react-router's generatePath()

Root Cause

The crash occurred because getDetailsLink() called getName() which returned undefined for certain cluster configurations. This undefined value was then passed to createRouteURL() → generatePath(), which expects all route parameters to be defined, causing the application to crash.

Steps to Test

1. Add a cluster with an ARN-style name (or any cluster where metadata.name is undefined)
2. Navigate to the Clusters page (/c/:cluster/cluster)
3. Verify the page loads without crashing
4. Check browser console for warning message about undefined cluster name
5. Confirm other clusters with valid names still generate proper detail links

Notes for the Reviewer

• The fix is defensive at the getDetailsLink() layer rather than modifying getName() to preserve its current behavior for other use cases
• Console warning provides debugging context (kind, cluster, namespace) to help identify problematic resources
• Returning empty string prevents malformed URLs while allowing calling code to handle gracefully

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Sagar-6203620715
Once this PR has been reviewed and has the lgtm label, please assign yolossn for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[skoeva]

Hi, would you mind updating the PR/commit title to match our commit guidelines?

[vyncent-t]

Looks good, wondering if this could be refined

[Copilot]

Pull request overview

This PR fixes a crash that occurs when displaying clusters with undefined metadata.name (specifically AWS EKS clusters with ARN-style names). The crash happened because getDetailsLink() passed undefined to generatePath(), which requires all route parameters to be defined.

Changes:

• Added null check in KubeObject.getDetailsLink() to validate object name before generating route URLs
• Returns empty string with console warning when object name is undefined instead of crashing
• Prevents TypeError: Expected "name" to be defined from react-router's generatePath()

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Sagar-6203620715]

HI @vyncent-t .Seems that the copilot review approves it too.
I have thoroughly tested the fix. Please approve the workflow for further tests.

Ready for review/merge!

[illume]

Thanks for this.

@Sagar-6203620715 is there a way we can have a link for these ones as well? This would make it so the user can not click on them.

Please check the other commit messages to see how they look and checkout the commit guidelines docs.

frontend: KubeObject: Prevent crash when cluster name is undefined in getDetailsLink

[vyncent-t]

This branch is behind, please update and rebase with the newest changes 👍